Change function t to translations in dashboard/_comment_moderate #6551

nstjean · 2019-10-25T18:13:22Z

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Update the file _comment_moderate.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

In this template we need to change the function named t(....) to be named as translations(...) on lines 4, 5, 6 and 8.

plots2/app/views/dashboard/_comment_moderate.html.erb

Lines 4 to 8 in 50164b1

    
                 <%= t('dashboard._comment_moderate.first_time_post') %> 
        
                 <a class="btn btn-outline-secondary btn-sm" href="/admin/publish_comment/<%= comment.id %>"><%= t('dashboard.moderate.approve') %></a> 
        
                 <a class="btn btn-outline-secondary btn-sm" href="/admin/mark_comment_spam/<%= comment.id %>"><%= t('dashboard.moderate.spam') %></a> 
        
               <% else %> 
        
                 <%= raw t('dashboard.moderate.pending_approval', :url => '/wiki/moderation') %>

After the changes it should look like this:

      <%= translation('dashboard._comment_moderate.first_time_post') %>
      <a class="btn btn-outline-secondary btn-sm" href="/admin/publish_comment/<%= comment.id %>"><%= translation('dashboard.moderate.approve') %></a>
      <a class="btn btn-outline-secondary btn-sm" href="/admin/mark_comment_spam/<%= comment.id %>"><%= translation('dashboard.moderate.spam') %></a>
    <% else %>
      <%= raw translation('dashboard.moderate.pending_approval', :url => '/wiki/moderation') %>

💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

The text was updated successfully, but these errors were encountered:

nstjean · 2019-10-25T18:14:13Z

Reserved for @saivoleti17

jaywar · 2019-10-25T18:29:26Z

@nstjean how can I get on a "wait list" to get a first-timers-only issue? Thank you.

nstjean · 2019-10-25T18:37:51Z

Hi @jaywahr - our list is located here: #6206 Just post and we will add you to the list! We'll get new issues up soon!

cesswairimu · 2019-10-27T09:38:57Z

@saivoleti17 already have a fto here publiclab/mapknitter#1086 ... @boolean5 you can solve this. Thanks all

boolean5 · 2019-10-27T11:23:22Z

Thank you @cesswairimu. I'm on it.

boolean5 · 2019-10-27T11:53:57Z

Now I see that @saivoleti17 has already submitted a PR (#6555) for this issue. I think it would be fair to let them complete their work. Please, let me know if any help is needed.

cesswairimu · 2019-10-27T13:42:08Z

Cool no worries

Anand-Theertha · 2019-10-28T05:50:04Z

Hello! I saw this issue under "No one assigned". Does this mean I can work on it even though it has been reserved for somebody? @nstjean

nstjean · 2019-10-29T13:18:01Z

Hi @Anand-Theertha ! There is already a pull request for this issue. We'll be making more first-time-only issues!

ghost · 2020-03-16T21:31:10Z

Hi,
I am Outreachy candidate and new to open source. Is this issue still open. Can I take it.

nstjean · 2020-03-17T15:06:20Z

@taysa91 You can work on this.

ghost · 2020-03-17T15:49:30Z

@nstjean Thank you. I did make a contribution but will also like to work on this one. Hope y'all don't mind.

nstjean · 2020-03-17T15:55:01Z

Hi @taysa91 ! We ask that people only do one FTO issue so that others have something to do to start out. If you have completed one already then next you can take a look at the bugs we have that need a little fix: https://github.com/publiclab/plots2/issues?q=is%3Aissue+is%3Aopen+label%3Abug

ghost · 2020-03-17T15:59:32Z

@nstjean Sure no problem, and thank you.

imanishbarnwal · 2020-06-12T06:08:03Z

Hello, @nstjean if no one is working on this issue. Can I do it? Thank You!!

cesswairimu · 2020-06-13T09:59:06Z

Hi @imanishbarnwal, sure go ahead..Thanks

imanishbarnwal · 2020-06-13T11:47:11Z

Hello, @cesswairimu I just send a PR kindly check that. Thank You!!

stale · 2020-10-07T00:11:05Z

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add "work in progress" label 🎉 . Otherwise, it will be closed if no further activity occurs in 5 days -- but you can always re-open it if you like! 💯 Thank you for your contributions 🙌 🎈.

Cadreia · 2020-10-15T09:37:10Z

Hi, @cesswairimu I would love to work on this

cesswairimu · 2020-10-15T10:21:07Z

@Cadreia, I see you have you already contributed to a first-timer issue. Would you mind leaving this one to a new contributor? and you could browse through the issues with the label help-wanted or bug

Cadreia · 2020-10-15T10:28:15Z

@cesswairimu okay, I'll do that. But I just linked a pull request for it. Do I close it?

cesswairimu · 2020-10-15T18:35:59Z

Yeah you could just close it if you are okay with that... thanks a lot 💯

Suiiyush · 2020-10-28T11:11:49Z

Hey, If it is not already assigned to anyone, can I work on this issue?

cesswairimu · 2020-10-29T12:16:43Z

Hi @Suiiyush, It looks like this has been solved already

plots2/app/views/dashboard/_comment_moderate.html.erb

Lines 4 to 8 in 50164b1

    
                 <%= t('dashboard._comment_moderate.first_time_post') %> 
        
                 <a class="btn btn-outline-secondary btn-sm" href="/admin/publish_comment/<%= comment.id %>"><%= t('dashboard.moderate.approve') %></a> 
        
                 <a class="btn btn-outline-secondary btn-sm" href="/admin/mark_comment_spam/<%= comment.id %>"><%= t('dashboard.moderate.spam') %></a> 
        
               <% else %> 
        
                 <%= raw t('dashboard.moderate.pending_approval', :url => '/wiki/moderation') %>

. Closing this. Thanks everyone.

nstjean added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Oct 25, 2019

nstjean mentioned this issue Oct 25, 2019

Create "first-timers-only" issues for newcomers 👋 #6206

Closed

64 tasks

nstjean mentioned this issue Oct 30, 2019

Making FTO issues from translation function #6579

Open

75 tasks

cesswairimu added the assigned label Jun 13, 2020

imanishbarnwal mentioned this issue Jun 13, 2020

Fixed Issue #8031

Closed

5 tasks

stale bot added the stale label Oct 7, 2020

cesswairimu removed the stale label Oct 7, 2020

cesswairimu mentioned this issue Oct 7, 2020

Create "first-timer-only" issues for new comers #7683

Closed

41 tasks

cesswairimu removed the assigned label Oct 7, 2020

Cadreia mentioned this issue Oct 15, 2020

changed function t to translation in _comment_moderate file #8585

Closed

5 tasks

cesswairimu closed this as completed Oct 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change function t to translations in dashboard/_comment_moderate #6551

Change function t to translations in dashboard/_comment_moderate #6551

nstjean commented Oct 25, 2019 •

edited

Loading

nstjean commented Oct 25, 2019

jaywar commented Oct 25, 2019

nstjean commented Oct 25, 2019 •

edited

Loading

cesswairimu commented Oct 27, 2019

boolean5 commented Oct 27, 2019

boolean5 commented Oct 27, 2019

cesswairimu commented Oct 27, 2019

Anand-Theertha commented Oct 28, 2019 •

edited

Loading

nstjean commented Oct 29, 2019

ghost commented Mar 16, 2020

nstjean commented Mar 17, 2020

ghost commented Mar 17, 2020

nstjean commented Mar 17, 2020

ghost commented Mar 17, 2020

imanishbarnwal commented Jun 12, 2020

cesswairimu commented Jun 13, 2020

imanishbarnwal commented Jun 13, 2020

stale bot commented Oct 7, 2020

Cadreia commented Oct 15, 2020

cesswairimu commented Oct 15, 2020

Cadreia commented Oct 15, 2020

cesswairimu commented Oct 15, 2020

Suiiyush commented Oct 28, 2020 •

edited

Loading

cesswairimu commented Oct 29, 2020

Change function t to translations in dashboard/_comment_moderate #6551

Change function t to translations in dashboard/_comment_moderate #6551

Comments

nstjean commented Oct 25, 2019 • edited Loading

🤔 What you will need to know.

📋 Step by Step

Please keep us updated

Is someone else already working on this?

🤔❓ Questions?

nstjean commented Oct 25, 2019

jaywar commented Oct 25, 2019

nstjean commented Oct 25, 2019 • edited Loading

cesswairimu commented Oct 27, 2019

boolean5 commented Oct 27, 2019

boolean5 commented Oct 27, 2019

cesswairimu commented Oct 27, 2019

Anand-Theertha commented Oct 28, 2019 • edited Loading

nstjean commented Oct 29, 2019

ghost commented Mar 16, 2020

nstjean commented Mar 17, 2020

ghost commented Mar 17, 2020

nstjean commented Mar 17, 2020

ghost commented Mar 17, 2020

imanishbarnwal commented Jun 12, 2020

cesswairimu commented Jun 13, 2020

imanishbarnwal commented Jun 13, 2020

stale bot commented Oct 7, 2020

Cadreia commented Oct 15, 2020

cesswairimu commented Oct 15, 2020

Cadreia commented Oct 15, 2020

cesswairimu commented Oct 15, 2020

Suiiyush commented Oct 28, 2020 • edited Loading

cesswairimu commented Oct 29, 2020

nstjean commented Oct 25, 2019 •

edited

Loading

nstjean commented Oct 25, 2019 •

edited

Loading

Anand-Theertha commented Oct 28, 2019 •

edited

Loading

Suiiyush commented Oct 28, 2020 •

edited

Loading