Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying of go to top button #7454

Closed
NitinBhasneria opened this issue Feb 10, 2020 · 15 comments
Closed

Displaying of go to top button #7454

NitinBhasneria opened this issue Feb 10, 2020 · 15 comments
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed

Comments

@NitinBhasneria
Copy link
Collaborator

At the top of webstie the go to top button should not be displayed which is displaying in this case.

Screenshot from 2020-02-10 18-53-07

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@NitinBhasneria NitinBhasneria added the bug the issue is regarding one of our programs which faces problems when a certain task is executed label Feb 10, 2020
@NitinBhasneria
Copy link
Collaborator Author

@VladimirMikulic @SidharthBansal please review this.

@VladimirMikulic
Copy link
Contributor

That would be a very nice UI improvement 👍
@NitinBhasneria you are doing great work!

@VladimirMikulic
Copy link
Contributor

I see what is the problem. The file scroll-func.js is in the root folder.
You should move it to plots2/app/assets/javascripts.

After you do that, add an entry in plots2/app/assets/javascripts/application.js to make it compile with other scripts.
You could as well format the scroll-func.js properly.

Thank you.

@NitinBhasneria
Copy link
Collaborator Author

yea, I got it thnx.

@stale stale bot added the stale label Oct 7, 2020
@publiclab publiclab deleted a comment from stale bot Oct 8, 2020
@stale stale bot removed the stale label Oct 8, 2020
@tawahpeggy
Copy link

i will like to check this issue out and work on it, if possible because i see its still open

@fiona-byte
Copy link
Contributor

Hi @NitinBhasneria if this issue is still open, I'd love to work on it

@cypherean
Copy link
Contributor

Hey @tawahpeggy @fiona-byte!
This issue was already solved in #6944 (merged might not be in production yet) and then in #7466.
You can check out the linked PR for more context. Maybe you can help finding the errors in that PR to get that merged.

All the best!

@fiona-byte
Copy link
Contributor

Thanks a lot @shreyaa-sharmaa

@cesswairimu
Copy link
Collaborator

@fiona-byte you can check on https://stable.publiclab.org/ I am checking too

@cesswairimu
Copy link
Collaborator

Looks like its still displaying, @shreyaa-sharmaa @fiona-byte could you please confirm..stable has all the changes on main

@cypherean
Copy link
Contributor

Hey @cesswairimu I can see that too.

@NitinBhasneria 's PR for the same mentions that it wasn't visible at all then? Strange. 🤔

@cesswairimu
Copy link
Collaborator

Yeah that's strange. @NitinBhasneria any ideas what could have gone wrong?

@fiona-byte
Copy link
Contributor

Hey @cesswairimu, I can see that too. I'm looking to see what has gone wrong

@cypherean
Copy link
Contributor

Any updates @fiona-byte?

@TildaDares
Copy link
Member

Resolved in #9588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants