Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve appearance of card image lists #165

Closed
3 tasks
bess opened this issue Oct 3, 2023 · 0 comments · Fixed by #181
Closed
3 tasks

Improve appearance of card image lists #165

bess opened this issue Oct 3, 2023 · 0 comments · Fixed by #181
Assignees
@leefaisonr

Comments

@bess
Copy link
Contributor

bess commented Oct 3, 2023 •
edited by hackartisan
Loading

We've added a heading to each one, which provides a little separation. But since they are a list they have bullet points which look weird; also the headings are showing up below the images. The card images run together a bit and adding a border would help separate them visually, but this is lower priority.

Acceptance Criteria

  • Display the heading above the card
  • Remove list bullets
  • add border for Card images
@leefaisonr leefaisonr self-assigned this Oct 5, 2023
@hackartisan hackartisan changed the title Add a visual separator between the card images Improve appearance of card image lists Oct 6, 2023
@hackartisan hackartisan mentioned this issue Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leefaisonr leefaisonr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove heading, style updates pulibrary/imagecat-rails
2 participants
@bess @leefaisonr