Add container build image commands #504
Conversation
gerrod3
force-pushed
the
container-build
branch
from
866f571
to
ef3750e
Compare
pulpcore/cli/container/context.py
Outdated
| tag: Optional[str], | ||
| artifacts: Optional[str], | ||
| ) -> Any: | ||
| body = {"containerfile_artifact": container_artifact, "tag": tag, "artifacts": artifacts} |
There was a problem hiding this comment.
I think, i would add a needs_capability here.
pulpcore/cli/container/context.py
Outdated
| @@ -153,6 +164,10 @@ class PulpContainerPushRepositoryContext(PulpContainerBaseRepositoryContext): | |||
| "roles": [PluginRequirement("container", "2.11.0")], | |||
| } | |||
|
|
|||
| def remove_image(self, digest: str) -> Any: | |||
| body = {"digest": digest} | |||
|
@gerrod3, are you able to continue working on this PR? We fixed the issues with the builder on the plugin's side (pulp/pulp_container@a6c2103). |
Yes, I can resume work on it now. |
gerrod3
force-pushed
the
container-build
branch
from
0c713c8
to
7cb86cc
Compare
mdellweg
changed the title
| ) | ||
| @click.option("--tag", help=_("A tag name for the new image being built.")) | ||
| @click.option( | ||
| "--artifacts", |
There was a problem hiding this comment.
With a new release of pulp-container (coming in 1 month), we will no longer support this argument, see pulp/pulp_container#1687. Instead, we will start using file_repository_version as a build context.
Should we close this PR or are we going to address this change soon-ish? The feature is still shipped as a tech-preview. However, I do not think we should support workflows using the artifacts endpoint anymore due to pulp/pulpcore#5525.
There was a problem hiding this comment.
I haven't touched this PR is a while, so maybe it's best to close it.
fixes: #424
TODO: