-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide configurable python versions in base images #586
Comments
The base image is |
What do we get from the "latest" part? We do not version them in any way, do we? Also we used |
We do version |
@dkliban The reason for that is that the containerfile differs based on branch, each tied to the pulpcore version. Mostly differences in C dependencies. Usually we just add new stuff in newer branches, but we do occasionally replace or remove stuff. |
@mikedep333 That makes sense. So then we should use more verbose tags that include the pulpcore version. @mdellweg what do you think about that? |
So: |
Yes, that's right. The word comes from the name of the branch where the Containerfile is coming from. |
Just keep in mind that the process for building containers for different versions of python should be easier in the future. We'll have to make the jump to python 3.11 soon as well. |
Is your feature request related to a problem? Please describe.
Right now all of the pulp base images use python 3.8. AAP increases the minimum python version with each release. This has been causing us problems in CI for some time, but has recently come to a head with the latest galaxy ng release which will depend on some shared ansible libraries that (currently) require a minimum of python 3.9. Because of this, we've had to increase the minimum python version in galaxy_ng to 3.9 (ansible/galaxy_ng#2048) and as a result the vanilla pulp-ci-centos base image no longer works with galaxy_ng.
Describe the solution you'd like
This is not the first or last time we will need to bump our minimum python version (as mentioned above this will happen with each AAP release). I would like some way to configure the python version at build time in the base images. OCI Env (https://github.com/pulp/oci_env/blob/main/base/Dockerfile#L12-L14) has the option to specify a different python version as a docker build arg, and I would like to have the same option in the base images. The base pulp images don't have to work the same way that OCI Env is set up right now (using the switch_python), since this is somewhat of a hacky approach. Rather, the base image should just install the python version that's provided in the build arg, rather than trying to change it after the fact.
Describe alternatives you've considered
Being able to run galaxy_ng using newer versions of python is a hard requirement for us.
The text was updated successfully, but these errors were encountered: