Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NODE_MODULE_NAME is ignored #110

Closed
ledniy opened this issue Mar 13, 2024 · 2 comments
Closed

NODE_MODULE_NAME is ignored #110

ledniy opened this issue Mar 13, 2024 · 2 comments
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@ledniy
Copy link

ledniy commented Mar 13, 2024

What happened?

Hello, I'm trying to publish our custom ported provider, but I can't find a way to override npm scope, the var NODE_MODULE_NAME from makefile has no affect at all, and I can't find where @pulumi/ comes from in sdk/nodejs/bin/package.json

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@ledniy ledniy added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Mar 13, 2024
@iwahbe
Copy link
Member

iwahbe commented Mar 14, 2024

Thanks for reporting this to us. As a workaround, you can specify the PackageName to override the name:

 provider/resources.go | 1 +
 1 file changed, 1 insertion(+)

diff --git a/provider/resources.go b/provider/resources.go
index ffd44a7..07df90b 100644
--- a/provider/resources.go
+++ b/provider/resources.go
@@ -121,6 +121,7 @@ func Provider() tfbridge.ProviderInfo {
 			// "aws_ami": {Tok: tfbridge.MakeDataSource(mainPkg, mainMod, "getAmi")},
 		},
 		JavaScript: &tfbridge.JavaScriptInfo{
+			PackageName: "@your-org/provider-name",
 			// List any npm dependencies and their versions
 			Dependencies: map[string]string{
 				"@pulumi/pulumi": "^3.0.0",

@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label Mar 14, 2024
@danielrbradley danielrbradley self-assigned this Nov 14, 2024
@danielrbradley danielrbradley added the resolution/fixed This issue was fixed label Nov 14, 2024
@danielrbradley
Copy link
Member

We've now removed NODE_MODULE_NAME from the makefile in #135 to avoid confusion. The correct approach as @iwahbe mentioned is to set this via the ProviderInfo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

3 participants