Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Claims restricts values to Strings #55

Open
Levi-Lesches opened this issue Mar 26, 2020 · 3 comments
Open

Custom Claims restricts values to Strings #55

Levi-Lesches opened this issue Mar 26, 2020 · 3 comments

Comments

@Levi-Lesches
Copy link
Contributor

Setting custom claims (via Auth.setCustomUserClaims) only allows the user to pass in a Map<String, String>, while the JS equivalent (as well as the official Node.js SDK) allows any value. Isn't it meant to be Map<String, dynamic>? I'm trying to set it to {"isAdmin": true}, but it's not allowed.

@Levi-Lesches
Copy link
Contributor Author

I could write a PR with the type change, if that would be helpful. There really shouldn't be any errors caused by this, since it is a more relaxed type of the original, and the JS functions are okay with that type anyway.

@Levi-Lesches
Copy link
Contributor Author

Fixed with #56

@Levi-Lesches
Copy link
Contributor Author

Just realized we forgot something: Auth.createCustomToken. I don't happen to use it, but it might be helpful to fix that too

@Levi-Lesches Levi-Lesches reopened this Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant