Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS Sierra - go 1.7 includes additional patches for the timeofday stuff. #67

Closed
idyll opened this issue Aug 15, 2016 · 10 comments
Closed

Comments

@idyll
Copy link

idyll commented Aug 15, 2016

My understanding is that 1.7RC6 includes additional fixes for macOS.

Once go 1.7 is released puma-dev will need to be compiled with it to maintain compatibility with macOS Sierra.

@evanphx
Copy link
Member

evanphx commented Aug 15, 2016

More than what was fixed in 1.6.3?

@evanphx
Copy link
Member

evanphx commented Aug 15, 2016

@idyll Are you using my official builds or building puma-dev yourself?

@nathany
Copy link

nathany commented Aug 15, 2016

@evanphx Yes, Go 1.6.3 had a patch for macOS Sierra beta 3, but then it was busted again in macOS Sierra beta 4. Go 1.7 rc6 is patched for that and Go 1.7 will be released shortly and is identical to rc6.

There is a plan to backport the fix to Go 1.4 (used for bootstrapping), but I don't think Go 1.6 will get a backport of the fix.

I work for @idyll. He has been building puma-dev himself until Go 1.7 is out and your official builds are updated to use it.

@evanphx
Copy link
Member

evanphx commented Aug 15, 2016

@nathany Thanks for the info! I'll begin doing 1.7 build as soon as it goes final (hopefully soon).

@nathany
Copy link

nathany commented Aug 15, 2016

In about 5 minutes. I'm following the progress on Slack. https://invite.slack.golangbridge.org/

@idyll
Copy link
Author

idyll commented Aug 15, 2016

Yeah sorry @evanphx but we need 1.7 now. :(
Thanks for taking care of this.

@nathany
Copy link

nathany commented Aug 15, 2016

@idyll
Copy link
Author

idyll commented Aug 15, 2016

Also, I have bad news about #66 I don't think they are related as I have been building my own puma-dev. I will test once you release an official update though and report back.

@evanphx
Copy link
Member

evanphx commented Aug 15, 2016

@nathany Well wasn't that great timing! I'll have a release out today built with 1.7.

@evanphx
Copy link
Member

evanphx commented Aug 17, 2016

The latest release v0.10 and all later releases will be built with Go 1.7.

@evanphx evanphx closed this as completed Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants