Skip to content

Commit

Permalink
Add spec test for add-apt-repository
Browse files Browse the repository at this point in the history 
This commit adds spec tests that validate the changes made in
the previous commit.
  • Loading branch information
@chelnak
chelnak committed Aug 18, 2022
1 parent c26ad2a commit 3a90419
Show file tree
Hide file tree
Showing 2 changed files with 83 additions and 56 deletions.
119 changes: 63 additions & 56 deletions spec/defines/ppa_spec.rb
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
# frozen_string_literal: true

require 'spec_helper'

def ppa_exec_params(user, repo, distro = 'trusty', environment = [])
[
environment: environment,
command: "/opt/puppetlabs/puppet/cache/add-apt-repository-#{user}-ubuntu-#{repo}-#{distro}.sh",
logoutput: 'on_failure',
]
end

describe 'apt::ppa' do
let :pre_condition do
'class { "apt": }'
Expand All @@ -24,15 +33,13 @@
}
end

let(:title) { 'ppa:needs/such.substitution/wow+type' }
let(:title) { 'ppa:needs/substitution' }

it { is_expected.not_to contain_package('python-software-properties') }
it {
is_expected.to contain_exec('add-apt-repository-ppa:needs/such.substitution/wow+type').that_notifies('Class[Apt::Update]').with(environment: [],
command: '/usr/bin/add-apt-repository -y ppa:needs/such.substitution/wow+type || (rm /etc/apt/sources.list.d/needs-ubuntu-such_substitution-wow_type-trusty.list && false)', # rubocop:disable Layout/LineLength
unless: '/usr/bin/test -f /etc/apt/sources.list.d/needs-ubuntu-such_substitution-wow_type-trusty.list && /usr/bin/test -f /etc/apt/trusted.gpg.d/needs_ubuntu_such_substitution-wow_type.gpg', # rubocop:disable Layout/LineLength
user: 'root',
logoutput: 'on_failure')
is_expected.to contain_exec('add-apt-repository-ppa:needs/substitution')
.that_notifies('Class[Apt::Update]')
.with(*ppa_exec_params('needs', 'substitution'))
}
end

Expand All @@ -57,24 +64,24 @@
let(:title) { 'ppa:user/foo' }

it {
is_expected.to contain_exec('add-apt-repository-ppa:user/foo').that_notifies('Class[Apt::Update]').with(environment: [],
command: '/usr/bin/add-apt-repository -y ppa:user/foo || (rm /etc/apt/sources.list.d/user-ubuntu-foo-wily.list && false)', # rubocop:disable Layout/LineLength
unless: '/usr/bin/test -f /etc/apt/sources.list.d/user-ubuntu-foo-wily.list && /usr/bin/test -f /etc/apt/trusted.gpg.d/user_ubuntu_foo.gpg', # rubocop:disable Layout/LineLength
user: 'root',
logoutput: 'on_failure')
is_expected.to contain_exec('add-apt-repository-ppa:user/foo')
.that_notifies('Class[Apt::Update]')
.with(*ppa_exec_params('user', 'foo', 'wily'))
}
end

describe 'package_name => software-properties-common' do
let :pre_condition do
'class { "apt": }'
end

let :params do
{
package_name: 'software-properties-common',
package_manage: true,
}
end

let :facts do
{
os: {
Expand All @@ -92,26 +99,21 @@
}
end

let(:title) { 'ppa:needs/such.substitution/wow' }
let(:title) { 'ppa:needs/substitution' }

it { is_expected.to contain_package('software-properties-common') }
it {
is_expected.to contain_exec('add-apt-repository-ppa:needs/such.substitution/wow').that_notifies('Class[Apt::Update]').with('environment' => [],
'command' => '/usr/bin/add-apt-repository -y ppa:needs/such.substitution/wow || (rm /etc/apt/sources.list.d/needs-ubuntu-such_substitution-wow-trusty.list && false)', # rubocop:disable Layout/LineLength
'unless' => '/usr/bin/test -f /etc/apt/sources.list.d/needs-ubuntu-such_substitution-wow-trusty.list && /usr/bin/test -f /etc/apt/trusted.gpg.d/needs_ubuntu_such_substitution-wow.gpg', # rubocop:disable Layout/LineLength
'user' => 'root',
'logoutput' => 'on_failure')
}

it {
is_expected.to contain_file('/etc/apt/sources.list.d/needs-ubuntu-such_substitution-wow-trusty.list').that_requires('Exec[add-apt-repository-ppa:needs/such.substitution/wow]').with('ensure' => 'file') # rubocop:disable Layout/LineLength
is_expected.to contain_exec('add-apt-repository-ppa:needs/substitution')
.that_notifies('Class[Apt::Update]')
.with(*ppa_exec_params('needs', 'substitution'))
}
end

describe 'package_manage => false' do
let :pre_condition do
'class { "apt": }'
end

let :facts do
{
os: {
Expand All @@ -128,25 +130,20 @@
},
}
end

let :params do
{
package_manage: false,
}
end

let(:title) { 'ppa:needs/such.substitution/wow' }
let(:title) { 'ppa:needs/substitution' }

it { is_expected.not_to contain_package('python-software-properties') }
it {
is_expected.to contain_exec('add-apt-repository-ppa:needs/such.substitution/wow').that_notifies('Class[Apt::Update]').with('environment' => [],
'command' => '/usr/bin/add-apt-repository -y ppa:needs/such.substitution/wow || (rm /etc/apt/sources.list.d/needs-ubuntu-such_substitution-wow-trusty.list && false)', # rubocop:disable Layout/LineLength
'unless' => '/usr/bin/test -f /etc/apt/sources.list.d/needs-ubuntu-such_substitution-wow-trusty.list && /usr/bin/test -f /etc/apt/trusted.gpg.d/needs_ubuntu_such_substitution-wow.gpg', # rubocop:disable Layout/LineLength
'user' => 'root',
'logoutput' => 'on_failure')
}

it {
is_expected.to contain_file('/etc/apt/sources.list.d/needs-ubuntu-such_substitution-wow-trusty.list').that_requires('Exec[add-apt-repository-ppa:needs/such.substitution/wow]').with('ensure' => 'file') # rubocop:disable Layout/LineLength
is_expected.to contain_exec('add-apt-repository-ppa:needs/substitution')
.that_notifies('Class[Apt::Update]')
.with(*ppa_exec_params('needs', 'substitution'))
}
end

Expand All @@ -156,6 +153,7 @@
apt::ppa { "ppa:user/foo2": }
'
end

let :facts do
{
os: {
Expand All @@ -172,23 +170,22 @@
},
}
end

let :params do
{
options: '',
package_manage: true,
require: 'Apt::Ppa[ppa:user/foo2]',
}
end

let(:title) { 'ppa:user/foo' }

it { is_expected.to compile.with_all_deps }
it { is_expected.to contain_package('software-properties-common') }
it {
is_expected.to contain_exec('add-apt-repository-ppa:user/foo').that_notifies('Class[Apt::Update]').with(environment: [],
command: '/usr/bin/add-apt-repository ppa:user/foo || (rm /etc/apt/sources.list.d/user-ubuntu-foo-trusty.list && false)', # rubocop:disable Layout/LineLength
unless: '/usr/bin/test -f /etc/apt/sources.list.d/user-ubuntu-foo-trusty.list && /usr/bin/test -f /etc/apt/trusted.gpg.d/user_ubuntu_foo.gpg', # rubocop:disable Layout/LineLength
user: 'root',
logoutput: 'on_failure')
is_expected.to contain_exec('add-apt-repository-ppa:user/foo')
.that_notifies('Class[Apt::Update]')
.with(*ppa_exec_params('user', 'foo'))
}
end

Expand All @@ -198,6 +195,7 @@
proxy => { "host" => "localhost" },
}'
end

let :facts do
{
os: {
Expand All @@ -214,21 +212,20 @@
},
}
end

let :params do
{
'options' => '',
'package_manage' => true,
}
end

let(:title) { 'ppa:user/foo' }

it { is_expected.to contain_package('software-properties-common') }
it {
is_expected.to contain_exec('add-apt-repository-ppa:user/foo').that_notifies('Class[Apt::Update]').with(environment: ['http_proxy=http://localhost:8080'],
command: '/usr/bin/add-apt-repository ppa:user/foo || (rm /etc/apt/sources.list.d/user-ubuntu-foo-trusty.list && false)', # rubocop:disable Layout/LineLength
unless: '/usr/bin/test -f /etc/apt/sources.list.d/user-ubuntu-foo-trusty.list && /usr/bin/test -f /etc/apt/trusted.gpg.d/user_ubuntu_foo.gpg', # rubocop:disable Layout/LineLength
user: 'root',
logoutput: 'on_failure')
is_expected.to contain_exec('add-apt-repository-ppa:user/foo')
.that_notifies('Class[Apt::Update]')
.with(*ppa_exec_params('user', 'foo', 'trusty', ['http_proxy=http://localhost:8080']))
}
end

Expand All @@ -238,6 +235,7 @@
proxy => { "host" => "localhost", "port" => 8180 },
}'
end

let :facts do
{
os: {
Expand All @@ -254,21 +252,20 @@
},
}
end

let :params do
{
options: '',
package_manage: true,
}
end

let(:title) { 'ppa:user/foo' }

it { is_expected.to contain_package('software-properties-common') }
it {
is_expected.to contain_exec('add-apt-repository-ppa:user/foo').that_notifies('Class[Apt::Update]').with(environment: ['http_proxy=http://localhost:8180'],
command: '/usr/bin/add-apt-repository ppa:user/foo || (rm /etc/apt/sources.list.d/user-ubuntu-foo-trusty.list && false)', # rubocop:disable Layout/LineLength
unless: '/usr/bin/test -f /etc/apt/sources.list.d/user-ubuntu-foo-trusty.list && /usr/bin/test -f /etc/apt/trusted.gpg.d/user_ubuntu_foo.gpg', # rubocop:disable Layout/LineLength
user: 'root',
logoutput: 'on_failure')
is_expected.to contain_exec('add-apt-repository-ppa:user/foo')
.that_notifies('Class[Apt::Update]')
.with(*ppa_exec_params('user', 'foo', 'trusty', ['http_proxy=http://localhost:8180']))
}
end

Expand All @@ -278,6 +275,7 @@
proxy => { "host" => "localhost", "port" => 8180, "https" => true },
}'
end

let :facts do
{
os: {
Expand All @@ -294,28 +292,28 @@
},
}
end

let :params do
{
options: '',
package_manage: true,
}
end

let(:title) { 'ppa:user/foo' }

it { is_expected.to contain_package('software-properties-common') }
it {
is_expected.to contain_exec('add-apt-repository-ppa:user/foo').that_notifies('Class[Apt::Update]').with(environment: ['http_proxy=http://localhost:8180', 'https_proxy=https://localhost:8180'],
command: '/usr/bin/add-apt-repository ppa:user/foo || (rm /etc/apt/sources.list.d/user-ubuntu-foo-trusty.list && false)', # rubocop:disable Layout/LineLength
unless: '/usr/bin/test -f /etc/apt/sources.list.d/user-ubuntu-foo-trusty.list && /usr/bin/test -f /etc/apt/trusted.gpg.d/user_ubuntu_foo.gpg', # rubocop:disable Layout/LineLength
user: 'root',
logoutput: 'on_failure')
is_expected.to contain_exec('add-apt-repository-ppa:user/foo')
.that_notifies('Class[Apt::Update]')
.with(*ppa_exec_params('user', 'foo', 'trusty', ['http_proxy=http://localhost:8180', 'https_proxy=https://localhost:8180']))
}
end

describe 'ensure absent' do
let :pre_condition do
'class { "apt": }'
end

let :facts do
{
os: {
Expand All @@ -332,15 +330,22 @@
},
}
end

let(:title) { 'ppa:user/foo' }

let :params do
{
ensure: 'absent',
}
end

it {
is_expected.to contain_file('/etc/apt/sources.list.d/user-ubuntu-foo-trusty.list').that_notifies('Class[Apt::Update]').with(ensure: 'absent')
is_expected.to contain_tidy("remove-apt-repository-script-#{title}")
.with('path' => '/opt/puppetlabs/puppet/cache/add-apt-repository-user-ubuntu-foo-trusty.sh')

is_expected.to contain_tidy("remove-apt-repository-#{title}")
.with('path' => '/etc/apt/sources.list.d/user-ubuntu-foo-trusty.list')
.that_notifies('Class[Apt::Update]')
}
end

Expand All @@ -362,6 +367,7 @@
},
}
end

let(:title) { 'ppa:user/foo' }

it do
Expand All @@ -386,6 +392,7 @@
},
}
end

let(:title) { 'ppa:user/foo' }

it do
Expand Down
20 changes: 20 additions & 0 deletions spec/unit/facter/apt_sources_spec.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# frozen_string_literal: true

require 'spec_helper'

describe 'apt_sources fact' do
subject { Facter.fact(:apt_sources).value }

before(:each) { Facter.clear }

describe 'returns a list of .list files' do
let(:sources_raw) { ['/etc/apt/sources.list.d/puppet-tools.list', '/etc/apt/sources.list.d/some-cli.list'] }
let(:sources_want) { ['sources.list', 'puppet-tools.list', 'some-cli.list'] }

before(:each) do
allow(Dir).to receive(:glob).and_return(sources_raw)
end

it { is_expected.to eq(sources_want) }
end
end

0 comments on commit 3a90419

Please sign in to comment.