Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another validation of ppa issue #1097

Open
ghost opened this issue Mar 29, 2023 · 0 comments
Open

Another validation of ppa issue #1097

ghost opened this issue Mar 29, 2023 · 0 comments

Comments

@ghost
Copy link

ghost commented Mar 29, 2023

Describe the Bug

In #1084 the validation was already updated once, now I apparently have found another special case: ppa:c2d4u.team/c2d4u4.0+.

Expected Behavior

The ppa should be used correctly and should not fail the validation.

Steps to Reproduce

Steps to reproduce the behavior:

apt::ppa { 'ppa:c2d4u.team/c2d4u4.0+':
  ensure => present,
}

Results in:

Evaluation Error: Error while evaluating a Function Call, Invalid PPA name: ppa:c2d4u.team/c2d4u4.0+

Environment

  • Version 9.0.2

Additional Context

The minimal change might be my hotfix, but maybe there is a more general solution to this problem.

-  if $name !~ /^ppa:([a-zA-Z0-9\-_.]+)\/([a-zA-z0-9\-_\.]+)$/ {
+  if $name !~ /^ppa:([a-zA-Z0-9\-_.]+)\/([a-zA-z0-9\-_\.\+]+)$/ {

Thank you for the great puppet module 🙇🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant