W: --force-yes is deprecated, use one of the options starting with --allow instead.

[XSpielinbox]

Describe the Bug

Puppet calls apt-get with the --force-yes option. This option has been deprecated and replaced by --allow-unauthenticated, --allow-downgrades, --allow-remove-essential and --allow-change-held-packages in apt 1.1 in 2015.

Expected Behavior

The Puppet apt module does not use --force-yes.

Steps to Reproduce

Steps to reproduce the behavior:

1. run puppet agent -t on a node that then has to downgrade a package.

Environment

• Version 9.0.2
• Platform: tested on Ubuntu 20.04 (should be the same in Ubuntu 16.04, Ubuntu 18.04 and Ubuntu 22.04 as well as all versions of Debian since at least Debian 10)

Additional Context

For enhanced backwards compatibility one might have an option that users that really need it, can explicitly enable to use the old --force-yes option.

[kenyon]

The only place I see --force-yes in this module is here, which is in the acceptance tests, not in code that Puppet would run:

puppetlabs-apt/spec/acceptance/apt_spec.rb

Line 51 in a6db503

run_shell('apt-get -y --force-yes upgrade')

I think you want to file this bug against puppet itself, not this apt module: https://github.com/search?q=repo%3Apuppetlabs%2Fpuppet%20--force-yes&type=code

[XSpielinbox]

Ok, thank you. Unfortunately, I cannot file an issue there as Issues are disabled for that GitHub repo and all links to the Jira Issue tracker are dead too...

[Ramesh7]

Thanks @XSpielinbox for raising and sorry for inconvenience, looks the README.md file still points to the old JIRA URL. I have created tracker ticket internally to update to new JIRA ticket.
Will update once this activity is done. Thanks again.

Also will review the module where ever there is --force-yes is get used, and do needful baed on the outcome.

[Ramesh7]

Have reviewed the module and as @kenyon mentioned we only have --force-yes in spec file otherwise we are not using this anymore. I will also use this issue to fix that part as long run.
Thanks @kenyon for being on top of this.

[Ramesh7]

Closing this as we have fixed in repo, the same will review for other modules and do needful, Thanks Team!!

[XSpielinbox]

Thank you @Ramesh7!
Looking forward to getting this solved in puppet itself too.