Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make launchAff_ only work on Aff Unit #203

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Make launchAff_ only work on Aff Unit #203

merged 4 commits into from
Mar 22, 2022

Conversation

i-am-the-slime
Copy link
Contributor

@i-am-the-slime i-am-the-slime commented Jun 4, 2021 •
edited
Loading

Description of the change

  1. Adds transitive dependencies to spago.dhall so the new version of Spago builds
  2. Closes Make launchAff_ operate only on Aff Unit #202

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • (not applicable) Added a test for the contribution

@JordanMartinez
Copy link
Contributor

CI fails because of some unused name warnings

@i-am-the-slime
Copy link
Contributor Author

Maybe it works like this?

@JordanMartinez
Copy link
Contributor

I've restarted CI.

And just to clarify, we're not expecting to merge this until the next round of breaking changes in the ecosystem, correct?

@thomashoneyman thomashoneyman added the type: breaking change A change that requires a major version bump. label Jun 16, 2021
@thomashoneyman
Copy link
Contributor

Yes, I'd like to leave this open until we're ready for a new breaking release of aff. That might come at the next compiler release, but it might come sooner if we have other breaking changes we can batch together.

@sigma-andex
Copy link

This could go in to the 0.15 release as well, right?

@thomashoneyman thomashoneyman added the purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 label Mar 22, 2022
@thomashoneyman thomashoneyman merged commit ff19847 into purescript-contrib:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make launchAff_ operate only on Aff Unit
4 participants
@i-am-the-slime @JordanMartinez @thomashoneyman @sigma-andex