-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that tests terminate #35
Comments
As I mentioned in #33, it is awkward to torn down the servers given how the tests are currently written. I could take a shot at fixing them, but I'd like to understand a bit better why they are structured like that, because there may be some context I'm not aware of. For the most part, they don't really run any assertions and simply print results to be inspected manually. When something is actually asserted, it uses |
I think the idea with these tests might have been that you run |
Sounds like a sensible thing to do, but then we would need separate tests suitable for CI, right? |
Yes; I wouldn't mind replacing them with tests which are suitable for CI, actually. |
I'm working on this in #45 |
Closed by #48 |
Currently, CI fails (as described in #33) because the the tests leave servers running until they are manually torn down. This results in timeout failures as in this failed run. We should fix the tests so that they terminate.
The text was updated successfully, but these errors were encountered: