-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: config option name not printing as application #128
Fix: config option name not printing as application #128
Conversation
…x for unsupported logger error
Quality Gate passedIssues Measures |
Apologies for the mess, Github published my PR before posting the Issue or editing the information within And sorry for the wait, I had this fix for a while but had other things on my mind 😅 |
Hi, looks ok, but it would be better if you cover this with 2 tests(with and without name option) can you add them? |
I'm sorry I don't think I understand what to check for and where |
79f3ce6
into
pustovitDmytro:hotfix/config-name
* Fix: config option name not printing as application; Minor grammar fix for unsupported logger error (#128) * Chore: adds tests to application name configuration --------- Co-authored-by: Dean Ayalon <deanayalon@me.com>
Fixed:
My apologies, the PR was posted before I had the chance to edit all the information
Tests do not throw errors, except
npm run test:package
- Which I am not sure about, is it my global Node version crashing it?Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Changes:
name
instead ofthis.name
when passing logged data property 'application'logger does not support ${lev} level
, also added alternative wording in commentFixes #129
closes #129
NPM Tests: