Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter feed items by reading access #10

Open
christydennison opened this issue Apr 19, 2012 · 2 comments
Open

Filter feed items by reading access #10

christydennison opened this issue Apr 19, 2012 · 2 comments

Comments

@christydennison
Copy link
Contributor

Feed items are not filtered by reading access, so a user could potentially see feed items for a profile that the user should not be able to see.

@pwnall
Copy link
Owner

pwnall commented Apr 19, 2012

I think the right way to solve this is to filter all shown feed comments by subject.can_read?(user). This involves (1) making sure that all possible subjects implement can_read? and (2) dealing with the fact that if we want to display 100 items, we might need to pull a lot more from the db.

@pwnall
Copy link
Owner

pwnall commented Apr 19, 2012

I'll think about this for a while, and see if I can come up with a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants