Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PanelView function #482

Closed
s3alfisc opened this issue Jun 6, 2024 · 3 comments
Closed

Implement PanelView function #482

s3alfisc opened this issue Jun 6, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@s3alfisc
Copy link
Member

s3alfisc commented Jun 6, 2024

Context

It's often useful (and also recommended, see this tweet) to study the treatment rollout in DiD settings.

In the R world, the panelView package supports functionality to easily inspect treatment rollout in a panel context

Task

Enrich the implementation of the panel_view function in #481.

It would be nice to add the following function arguments:

  • by_timing, which sorts units by the timing of receiving the treatment
  • pre_post
  • leave_gap
  • collapse_history

Additionally, the function should throw a warning if there is a missing time variable for a given cohort.

@s3alfisc s3alfisc added enhancement New feature or request good first issue Good for newcomers labels Jun 6, 2024
@s3alfisc
Copy link
Member Author

s3alfisc commented Jul 3, 2024

Hi @apoorvalal , Rafi (@rafimikail) has signaled his interest to work on this. He'd pick up the work you started in #481. I guess you wouldn't insist on continuing to work on this? 😄

To get started, have you already taken a look at the vignette of the PanelView R package @rafimikail? This PR would mostly consist of adding the function arguments listed above as implemented in PanelView to Appoorva's PR and of course any other feature that you particularly like or see value in =) Is there anything you think we should be prioritizing @apoorvalal?

@apoorvalal
Copy link
Member

ah yes sorry for letting this slide; yes by all means feel free to pick this up @rafimikail.

@rafimikail
Copy link
Contributor

Hi @s3alfisc , I've taken a quick glance, but I haven't gone in-depth yet. I'll make sure to dive into the details of the R package soon.

Also thank you @apoorvalal and @s3alfisc for letting me carry on with this and giving me opportunity 😄! Please assign me with this issue @s3alfisc =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants