Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create literals and move all literals to literals.py file #671

Open
s3alfisc opened this issue Oct 26, 2024 · 2 comments
Open

Create literals and move all literals to literals.py file #671

s3alfisc opened this issue Oct 26, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@s3alfisc
Copy link
Member

s3alfisc commented Oct 26, 2024

It would be nice if we consequently used string literals for type checks as in here.

To do so, we would set up a dedicated file, literals.py, and move all "stringly-typed" function arguments to the file.

We could start with the arguments to the feols and fepois APIs, for which we have the following stringly-typed arguments:

  • vcov : Union[str, dict[str, str]] -> here "str" part could be either "iid", "hetero", "hc1", "hc2", or "hc3"
  • weights_type: either "aweights" or "fweights"
  • fixef_rm: "singleton" or "none"
  • solver: "np.linalg.lstsq" or "np.linalg.solve"

cc @leostimpfle

Maybe of interest to @marcandre259 or @rafimikail ?

@s3alfisc s3alfisc added enhancement New feature or request good first issue Good for newcomers labels Oct 26, 2024
@marcandre259
Copy link
Contributor

I've starting working on #557 with the weights for did, it's an issue that's also interesting for my work, so motivating to look at.

If @rafimikail or another contributor is actively working on #557 however, or once I get something done there, I would be happy to pick up this issue.

@s3alfisc
Copy link
Member Author

Ah, very cool! I don't think Rafi is currently working on #557 so I don't think there are any double efforts at the moment =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants