Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpdf2-manual.pdf: fix rendering of Hindi tutorial #381

Closed
Lucas-C opened this issue Apr 5, 2022 · 5 comments
Closed

fpdf2-manual.pdf: fix rendering of Hindi tutorial #381

Lucas-C opened this issue Apr 5, 2022 · 5 comments

Comments

@Lucas-C
Copy link
Member

Lucas-C commented Apr 5, 2022

The fpdf2 PDF manual ( https://pyfpdf.github.io/fpdf2/fpdf2-manual.pdf ) recently incorporated the tutorials in all languages.

However the Hindi tutorial does not get rendered well at all.

We should find a way to configure the mkdocs plugin used to properly render this tutorial, maybe by specifying the font to use for this section.

Or just skip those pages from the PDF manual for now.

@gmischler
Copy link
Collaborator

That might turn out to be a challenge on several levels.

I don't see any non-latin text in the WeasyPrint examples, and at first glance it looks like a highly automated solution with limited configurability. I think I'm not going to enter any bets either way for now...

@Lucas-C
Copy link
Member Author

Lucas-C commented Apr 7, 2022

Damn, that sure looks like a lot of trouble for a PDF export of the online HTML documentation...

Maybe we should go for option B then: tell mkdocs-with-pdf to skip this tutorial,
and just not include it in the resulting PDF.

@gmischler
Copy link
Collaborator

Or option C: fix #365 and do it with fpdf... 😉

@gmischler
Copy link
Collaborator

@Lucas-C, now that #820 has landed, maybe we can switch to using fpdf2 itself for generating the PDF manual?
Then we could include the tutorials in all languages.

@Lucas-C
Copy link
Member Author

Lucas-C commented Aug 11, 2023

@Lucas-C, now that #820 has landed, maybe we can switch to using fpdf2 itself for generating the PDF manual? Then we could include the tutorials in all languages.

This seems like a big task to me, but I'm open to this if anyone want to do it! 😊

Maybe a first would be to look at how https://github.com/orzih/mkdocs-with-pdf does PDF generation,
and see how fpdf2 could be used instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants