Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in customer scenario notebook #437

Closed
vsyrgkanis opened this issue Mar 21, 2021 · 2 comments · Fixed by #441
Closed

Error in customer scenario notebook #437

vsyrgkanis opened this issue Mar 21, 2021 · 2 comments · Fixed by #441
Assignees
Labels
bug Something isn't working

Comments

@vsyrgkanis
Copy link
Collaborator

In cell [16] of the multi-investment attribution notebook:
https://github.com/microsoft/EconML/blob/7005b242531669854f9e0b6b944b590b9b4fdf66/notebooks/CustomerScenarios/Case%20Study%20-%20Multi-investment%20Attribution%20at%20A%20Software%20Company.ipynb

I believe it should be X.shape[0] in both places.

@vsyrgkanis vsyrgkanis added the bug Something isn't working label Mar 21, 2021
@vsyrgkanis
Copy link
Collaborator Author

Also I think in the end where you evaluate the ROI of each policy ,we should be using the true ROI, not the ROI estimated by the model, if we want to understand how we really performed.

So maybe you add another cell that displays the same comparison, but now with ground truth, something like:

true_roi = np.zeros((X.shape[0], 4))
true_roi[:, 1:3] = TE_fn(X)
true_roi[:, 3] = true_roi[:, 1:3].sum(axis=1)
true_roi[:, 1:] -= cost_fn(multi_data)

and report the numbers in the table with the true_roi

@vsyrgkanis
Copy link
Collaborator Author

Addressed by #441.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants