Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On OSX, py5_tools.save_frames(), animated_gif(), and capture_frames() trip up the animation thread #58

Closed
hx2A opened this issue Jan 26, 2022 · 4 comments

Comments

@hx2A
Copy link
Collaborator

hx2A commented Jan 26, 2022

The functions do not return after adding the hooks because it prints out progress messages. Those progress messages should be handled differently or skipped altogether.

@hx2A
Copy link
Collaborator Author

hx2A commented Jan 26, 2022

Can capture_frames() even be useful on OSX?

@hx2A
Copy link
Collaborator Author

hx2A commented Feb 21, 2022

Totally rebuilt these methods so they can return right away and work on OSX. The progress messages are printed to the Jupyter output cell associated with the code, and allows the user to move on to another cell while these are running.

@hx2A hx2A closed this as completed Feb 21, 2022
@villares
Copy link
Collaborator

Have you tested py5_tools.animated_gif(} outside the Jupyter environment?
I couldn't make it work yet, but I know a new release is coming out, I think next week I'll ask you some questions about this...

@hx2A
Copy link
Collaborator Author

hx2A commented Mar 22, 2022

I believe they will work with the generic Python interpreter but it doesn't look like they will work with the run_sketch command line utility. However, it would be great if that was possible, because this would be great functionality to make available for Thonny users. Looking at the code, I see where the issue is, but am not comfortable modifying that right before a release. It shouldn't be a big deal to fix this. I'll add it to the todo list for the release after this upcoming one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants