-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hudpy: A Python interface for the US Department of Housing and Urban Development APIs #54
Comments
Hi @etam4260 and welcome to pyOpenSci! This definitely looks in scope at first glance. Let me check in with everyone and we will get back to you by early next week. |
Hi again @etam4260 sorry for the delayed reply. But I would really like to get you a review. Please reply confirming that you would still like to initiate the review process. |
Hi @NickleDave, thanks for the response. I've been taking a break from OSS development for a bit. Since I have submitted the rhud package for review, I am still working on changes for those and have not "mapped" over the feedback to the python version. I first would like to work on making those changes before getting formal feedback as I think the reviewers' comments will have a lot of overlap with reviews given so far in the R version. I think in two weeks should be fine. Thanks, again! |
Makes sense to me @etam4260! Just let us know when you're ready |
hey there @etam4260 ! I really appreciate the conversation above and the acknowledgement that you needed a break! I wanted to check back in to see if you are still interested in working through a review with us or if you'd like to wait. IF you would like to wait - no problem. I will close this issue for now, and you can reopen it when you are ready. If you are ready now please just let us know. Either way we are so happy to have you here at pyOpenSci - just let us know what timeing works best for you. If i don't hear from you within the next week, I will go ahead and close the issue. You can still reopen it at any time. @NickleDave thank you again for serving as editor here!! 💥 |
Hi @lwasser yes, I haven't gotten much time to mess around/revise my work for awhile. No problem. Perfectly fine if this gets closed for now. |
ok no problem @etam4260 ! I am going to close this issue with this comment. But please do feel free to resubmit in the future if you find that you have more time to devote to the review process. And keep an eye on pyopensci as we grow the organization and the community. i'm hopeful that we can really help the community of maintainers like you! All the best. |
Submitting Author: @etam4260
Package Name: hudpy
One-Line Description of Package: A Python Interface to the US Department of Housing and Urban Development APIs
Repository Link: https://github.com/etam4260/hudpy
Version submitted: 0.2.0
Editor: TBD
Reviewer 1: TBD
Reviewer 2: TBD
Archive: TBD
Version accepted: TBD
Description
Currently the R version is under peer review at ROpenSci:
ropensci/software-review#524
This package is a mapped over version from R to Python.
This package gives users access to the US Department of Housing and Urban Development APIs
available at HUD User:
https://www.huduser.gov/hudapi/public/login
This also has additional wrappers onto of the data provided from these APIs to determine if US geographies intersect
based on addresses and (cross walking a US dataset) explained in this paper below:
Wilson, Ron and Din, Alexander, 2018. “Understanding and Enhancing the U.S.
Department of Housing and Urban Development’s ZIP Code Crosswalk Files,”
Cityscape: A Journal of Policy Development and Research, Volume 20 Number 2, 277
https://www.huduser.gov/portal/periodicals/cityscpe/vol20num2/ch16.pdf
Scope
NA
It is a data retrieval package because it retrieves data from an API. It is data munging package because it implements the concept of cross walking a file (converting a dataset described in one US geographic identifier into another) explained in the paper mentioned above.
I am hoping to reach professors, researchers, and students with this package. This gives access to the crosswalk files which is a geospatial technique described very well in these journal articles:
Din, Alexander and Wilson, Ron, 2020. “Crosswalking ZIP Codes to Census Geographies: Geoprocessing the U.S. Department of Housing & Urban Development’s ZIP Code Crosswalk Files,” Cityscape: A Journal of Policy Development and Research, Volume 22, Number 1, https://www.huduser.gov/portal/periodicals/cityscpe/vol22num1/ch12.pdf
Wilson, Ron and Din, Alexander, 2018. “Understanding and Enhancing the U.S. Department of Housing and Urban Development’s ZIP Code Crosswalk Files,” Cityscape: A Journal of Policy Development and Research, Volume 20 Number 2, 277 – 294.
Not any that I know of.
@tag
the editor you contacted:NA
Technical checks
For details about the pyOpenSci packaging requirements, see our packaging guide. Confirm each of the following by checking the box. This package:
In terms of vignette, I am assuming you are referring to a Jupyter notebook style documentation. I don't have this, but
there is a website with vignette like documentation: https://etam4260.github.io/hudpy/build/html/index.html
Publication options
JOSS Checks
paper.md
matching JOSS's requirements with a high-level description in the package root or ininst/
.Note: Do not submit your package separately to JOSS
Are you OK with Reviewers Submitting Issues and/or pull requests to your Repo Directly?
This option will allow reviewers to open smaller issues that can then be linked to PR's rather than submitting a more dense text based review. It will also allow you to demonstrate addressing the issue via PR links.
Code of conduct
P.S. *Have feedback/comments about our review process? Leave a comment here
I feel like there should be a section for details that might not fit into any of the questions above.
Currently my package does not implement caching, but the skeleton code is currently in the module for future
implementation. It will work similar to the caching implemented in the rhud package currently being reviewed by ROpenSci.
I have not looked into the PEP 8 style guide yet, but will make sure to review that.
Editor and Review Templates
Editor and review templates can be found here
The text was updated successfully, but these errors were encountered: