Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for improvements to install_KLU_Sundials.py and build infrastructure #3651

Closed
5 tasks done
agriyakhetarpal opened this issue Dec 21, 2023 · 1 comment
Closed
5 tasks done
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours difficulty: medium Will take a few days priority: low No existing plans to resolve

Comments

@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented Dec 21, 2023

Warning

Following an imminent migration for the build system and/or choice of build-backend for PyBaMM, not all of the listed points may not be applicable for completion. Please refer to #3564 for more information.

There are a number of improvements that can be introduced to improve the installation of the build-time dependencies (SuiteSparse and SUNDIALS) and the IDAKLU extension module and general improvements to the installation scripts:

These tasks have a mixture of easy and medium difficulty. Some of them have a higher priority than the rest, I am glad to take those up myself.

Tip

The rest of the tasks have been moved to #3564.

@agriyakhetarpal
Copy link
Member Author

Closing this issue and moving individual remaining items over to #3564 – they can be tracked better there and that issue is now more relevant to the discussion.

@agriyakhetarpal agriyakhetarpal closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2024
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
…ent.futures for efficiency

This update replaces the previous wget-based approach with urllib from the Python standard library. Additionally, it introduces parallelization using concurrent.futures, specifically employing ThreadPoolExecutor to download SuiteSparse and SUNDIALS tarballs simultaneously. This parallelization significantly reduces the download time.

Resolves: pybamm-team#3651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours difficulty: medium Will take a few days priority: low No existing plans to resolve
Projects
None yet
Development

No branches or pull requests

1 participant