Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests and integration tests together to speed up PR builds #4099

Closed
agriyakhetarpal opened this issue May 17, 2024 · 2 comments · Fixed by #4108
Closed

Run unit tests and integration tests together to speed up PR builds #4099

agriyakhetarpal opened this issue May 17, 2024 · 2 comments · Fixed by #4108
Assignees
Labels
CI/CD Related to continuous integration, continuous deployment (GitHub Actions, workflows, testing, etc.) difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows

Comments

@agriyakhetarpal
Copy link
Member

Description

The PR builds run unit tests and integration tests separately right now, which leads to a lot of runner requests from GitHub Actions (more than what are available to us concurrently with a non-team or non-enterprise plan), and as a result they usually take up to an hour to complete. A way to improve the PR build times would be to run nox -s unit and nox -s integration together till the time #3617 is finished and the integration tests are migrated to support pytest invocations, because the unit tests after #3857 run in parallel, and usually pass within ~5-6 minutes across platforms (and are much faster within the range of <3 minutes on larger runners such as the macos-14 ones).

Proposed implementation

Modify test_on_push.yml to run nox -s unit and nox -s integration in the same step, remove one (either) of the redundant unit or the integration jobs, and adjust the job names as necessary.

Additional context

Discussed in the community bonding GSoC meeting on 17/05/2024 with @Saransh-cpp and @arjxn-py – cc: @prady0t (you'll have to comment on the issue in order for us to assign you to this)

@agriyakhetarpal agriyakhetarpal added difficulty: easy A good issue for someone new. Can be done in a few hours CI/CD Related to continuous integration, continuous deployment (GitHub Actions, workflows, testing, etc.) priority: medium To be resolved if time allows labels May 17, 2024
@prady0t
Copy link
Contributor

prady0t commented May 17, 2024

I'll start working on this right away. You can assign this to me.

@agriyakhetarpal
Copy link
Member Author

Adding xrefs: #3662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related to continuous integration, continuous deployment (GitHub Actions, workflows, testing, etc.) difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants