[BUG]: missing version type in release

[sergiud]

Required prerequisites

• Make sure you've read the documentation. Your issue may be addressed there.
• Search the issue tracker and Discussions to verify that this hasn't already been reported. +1 or comment there if it has.
• Consider asking first in the Gitter chat room or in a Discussion.

Problem description

When consuming pybind11 by means of find_package, the following message is generated by CMake:

-- Found pybind11: /home/sergiu/proj/devel/pybind11/install/include (found version "2.8.1" )
                                                                                          ^

Note the spurious space before the closing parenthesis. It seems that this is where the version type is supposed to appear:

pybind11/tools/pybind11Config.cmake.in

Line 231 in 270b11d

"Found pybind11: ${pybind11_INCLUDE_DIR} (found version \"${pybind11_VERSION}\" ${pybind11_VERSION_TYPE})"

For some reason, however, the corresponding CMake variable is empty.

Reproducible example code

No response

[Skylion007]

@henryiii This looks like something wrong with our release version flow using Nox. Also pinging @rwgk since he ran the release script this time.

[henryiii]

I could be wrong, but I thought this was supposed to be empty for release versions. The spacing is a problem, but I'm pretty sure it's supposed to be empty for releases.

[sergiud]

Thanks for looking into this issue. I observe the same behavior both when I install pybind11 using plain CMake but also in the version packaged for Arch Linux using setup.py.

[henryiii]

I think it's because it's the correct behavior. We just haven't bothered to remove the extra space (though we probably should).

[sergiud]

I see. The simplest fix would be to report the version type as part of the version string, e.g., as 2.8.1dev1. This would be consistent with how versions are generally reported by CMake in terms of find_package_handle_standard_args and maybe even use the latter instead (e.g., in CONFIG mode).

[henryiii]

That is what is done (though it is pulled from the version string, rather than the other way around). But for 2.8.1, there is no version type, since it's a final release. If you use master, it should be reported as dev1, which as far as I can tell, it is.

[henryiii]

Oh, I see what you mean, about the fix for the space. Okay, though I think the "." is not included, so you'd still have to add that.

[sergiud]

As far as I can see, the version is still reported as "2.9.0" dev1. I, however, propose changing it to "2.9.0dev1". Does this make sense?

[henryiii]

Sorry, I'm only half here, it seems. :) Yes, that sounds reasonable and should be easy.

[henryiii]

Would you like to make the change?

[sergiud]

Sure.