Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: undefined Boost::headers with Boost::boost found #5138

Closed
3 tasks done
Teloze opened this issue May 24, 2024 · 1 comment · Fixed by #5149
Closed
3 tasks done

[BUG]: undefined Boost::headers with Boost::boost found #5138

Teloze opened this issue May 24, 2024 · 1 comment · Fixed by #5149
Labels
triage New bug, unverified

Comments

@Teloze
Copy link

Teloze commented May 24, 2024

Required prerequisites

What version (or hash if on master) of pybind11 are you using?

4d0fced

Problem description

in the tests/CMakeLists.txt the target Boost::headers is empty if Boost::boost found. I believe the problem is at

set_property(TARGET Boost::boost PROPERTY INTERFACE_LINK_LIBRARIES Boost::boost)
where the TARGET should be Boost::headers, instead of Boost::boost.

Reproducible example code

I use a custom install of Boost 1.71.0 with CMake 3.12.1 on a system (CentOS7) with Boost < 1.51. The custom Boost is found during CMake but the system library is included during make.

Is this a regression? Put the last known working version here if it is.

Not a regression

@Teloze Teloze added the triage New bug, unverified label May 24, 2024
@henryiii
Copy link
Collaborator

That is correct, it is supposed to match the line below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage New bug, unverified
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants