Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working around Centos 8 failure. #3030

Merged
merged 5 commits into from
Jun 18, 2021
Merged

Working around Centos 8 failure. #3030

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45effaf
Skiping `yum install gcc-c++` for Centos 8.
Jun 6, 2021
574d4dc
Undoing failed experiment (restoring original version from master).
Jun 17, 2021
a573f79
Experiment using -DCMAKE_BUILD_TYPE=Debug for Centos 8.
Jun 17, 2021
6068817
Moving comment because the current placement seems to mess up the cma…
Jun 17, 2021
34b07f7
Using `echo > VAR_XXX` and `$(cat VAR_XXX)` trick to emulate using va…
Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,10 +592,21 @@ jobs:
- name: Install dependencies
run: python3 -m pip install cmake -r tests/requirements.txt --prefer-binary

- name: VAR_BUILD_TYPE 7
if: matrix.centos == 7
run: echo Release > VAR_BUILD_TYPE

# Using Debug to avoid segfault that appeared around 2021-06-04,
# apparently when the gcc version changed from 8.3 to 8.4.
- name: VAR_BUILD_TYPE 8
if: matrix.centos == 8
run: echo Debug > VAR_BUILD_TYPE

- name: Configure
shell: bash
run: >
cmake -S . -B build
-DCMAKE_BUILD_TYPE=$(cat VAR_BUILD_TYPE)
-DPYBIND11_WERROR=ON
-DDOWNLOAD_CATCH=ON
-DDOWNLOAD_EIGEN=ON
Expand Down