Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing all warning pragmas that have not effect. #3127

Merged
merged 1 commit into from
Jul 17, 2021

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Jul 17, 2021

The 10 (out of 21) obsolete pragmas were identified via experiments under draft/scratch PR #3125.

@rwgk
Copy link
Collaborator Author

rwgk commented Jul 17, 2021

Deflaking.

@rwgk rwgk closed this Jul 17, 2021
@rwgk rwgk reopened this Jul 17, 2021
@henryiii
Copy link
Collaborator

I was guessing we'd have removed the need for some of these with all the cleanups we have been doing!

@rwgk rwgk marked this pull request as ready for review July 17, 2021 15:54
@rwgk rwgk merged commit 34f587d into pybind:master Jul 17, 2021
@rwgk rwgk deleted the pragma_block_rm_unnecessary branch July 17, 2021 15:54
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jul 17, 2021
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants