Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(perf): Add a missing noexcept to a pytype constructor #3236

Merged
merged 2 commits into from
Sep 2, 2021
Merged

(perf): Add a missing noexcept to a pytype constructor #3236

merged 2 commits into from
Sep 2, 2021

Conversation

Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Sep 2, 2021 •
edited
Loading

Adds a missing noexcept to a PyType constructors for perf reasons.

Description

  • I noticed a move constructor that didn't have noexcept which prevents it from being used in certain contexts (like being moved into a STL vector), this rectifies that issue.

Suggested changelog entry:

* Perf: Mark a pytype move constructor as noexcept

@Skylion007
Add a missing noexcept to pytypes constructor.
035c206 
Adds a few missing noexcept to PyType constructors for perf reasons.
@Skylion007 Skylion007 requested review from rwgk and henryiii September 2, 2021 16:11
@Skylion007 Skylion007 changed the title (perf): Add a couple of missing noexcepts to pytypes constructor (perf): Add a couple of missing noexcepts to pytypes constructors Sep 2, 2021
@Skylion007 Skylion007 changed the title (perf): Add a couple of missing noexcepts to pytypes constructors (perf): Add a missing noexcept to a pytype constructor Sep 2, 2021
rwgk
rwgk approved these changes Sep 2, 2021
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Aaron!

@Skylion007 Skylion007 merged commit d71ba0c into master Sep 2, 2021
@Skylion007 Skylion007 deleted the pytypes_noexcept branch September 2, 2021 19:18
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Sep 2, 2021
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Sep 16, 2021
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

@henryiii henryiii Awaiting requested review from henryiii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skylion007 @rwgk @henryiii