fix(cmake): make library component optional #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
LecrisUT
reviewed
Aug 21, 2023
devw4r
added a commit
to devw4r/namigator
that referenced
this pull request
Sep 17, 2023
wjakob
added a commit
to wjakob/nanobind
that referenced
this pull request
Oct 27, 2023
Ported from a pybind11 PR by @henryiii: pybind/pybind11#4805
|
LGTM, nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a probably long standing bug where
set(PYBIND11_FINDPYTHON ON)couldn't be used in manylinux. Fix #4802.Suggested changelog entry: