Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): enum's __str__ docstring #4827

Merged
merged 2 commits into from
Aug 30, 2023
Merged

fix(types): enum's __str__ docstring #4827

merged 2 commits into from
Aug 30, 2023

Conversation

sizmailov
Copy link
Contributor

@sizmailov sizmailov commented Aug 30, 2023 •
edited by henryiii
Loading

Description

Fix incorrect signature name(self: handle) -> str\n in enum's __str__ docstring.
Introduced in #2637

Suggested changelog entry:

   Fixed ``base_enum.__str__`` docstring

rwgk
rwgk approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@rwgk rwgk merged commit e705fb5 into pybind:master Aug 30, 2023
82 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Aug 30, 2023
@sizmailov sizmailov deleted the fix-enum-str-docstring branch September 3, 2023 11:47
@henryiii henryiii changed the title Fix enum's __str__ docstring fix(types): enum's __str__ docstring Nov 15, 2023
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

@rwgk rwgk rwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sizmailov @rwgk @henryiii