Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Python 3.13t with GIL #5139

Merged
merged 7 commits into from
May 28, 2024
Merged

fix: Python 3.13t with GIL #5139

merged 7 commits into from
May 28, 2024

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented May 24, 2024 •
edited
Loading

Description

First step toward #5112, just trying to compile against 3.13t.

Suggested changelog entry:

* Compile against Python 3.13t in CI.
* Return ``py::ssize_t`` from ``.ref_count()`` instead of ``int``

henryiii added 2 commits May 24, 2024 17:08
@henryiii
ci: try Python 3.13t
15bc5f3 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
fix: support Python 3.13t
c57a840 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
henryiii commented May 24, 2024
View reviewed changes
include/pybind11/pytypes.h Outdated Show resolved Hide resolved
henryiii added 2 commits May 24, 2024 20:10
@henryiii
fix: patch PyPy
f74d23a 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
tests: one more int cast
0d95846 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/ci/313t branch from adeeee7 to 0d95846 Compare May 25, 2024 03:03
@henryiii henryiii marked this pull request as ready for review May 25, 2024 03:18
@henryiii henryiii changed the title ci: try Python 3.13t ci: Python 3.13t with GIL May 25, 2024
@henryiii
tests: cleanup
a7c3377 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii mentioned this pull request May 26, 2024
Closed
rwgk
rwgk requested changes May 27, 2024
View reviewed changes
tests/test_class.py Outdated Show resolved Hide resolved
@henryiii
refactor: use named constant in tests for immortal refcounts
884524c 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
rwgk
rwgk approved these changes May 28, 2024
View reviewed changes
tests/pybind11_tests.cpp Show resolved Hide resolved
@henryiii henryiii changed the title ci: Python 3.13t with GIL fix: Python 3.13t with GIL May 28, 2024
@henryiii
docs: move comment about free threaded Python
72a6337 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii merged commit ae6432b into pybind:master May 28, 2024
83 checks passed
@henryiii henryiii deleted the henryiii/ci/313t branch May 28, 2024 13:08
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label May 28, 2024
@henryiii henryiii mentioned this pull request May 30, 2024
Merged
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryiii @rwgk