-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing integrity attr on pybind11 http_archive #102
Comments
Thanks for fixing this, I just looked into the warning today so perfect timing. Will you also issue a new release with the fixed internal_configure.bzl? |
I'll try to find some cycles on Monday? I have never cut a release before, nor have I submitted anything to BCR. It should be straightforward but will probably take an hour or two. |
If you only have time to create the pybind11_bazel release that's still helpful as anyone can bump the BCR version. Since there's a Release GitHub action I think you'd just need to:
EDIT: there are instructions here to bump the version: https://github.com/bazelbuild/bazel-central-registry/blob/main/docs/README.md#contribute-a-bazel-module which says:
|
@jiawen Friendly ping to create a new tag: #102 (comment), don't worry about the BCR update if you're short on time. |
Done. Sorry about that - crunch time at work yadda yadda. |
NP, a reasonable decision in hindsight as this was not as easy as it looked. The new release lacks the static archives from https://github.com/pybind/pybind11_bazel/releases/tag/v2.12.0 and the BCR refuses to use the new release: It seems that either you followed a different process to just pushing a tag or GitHub decided to automatically create a release, and this blocked the Release action which failed with If the former, you could presumably delete the release and then click Rerun on the action. |
Ack, it's my first raygun. Let me try that again. If you need higher bandwidth, feel free to find me at the same handle on the Bazel slack. |
@drigz Give that a spin? I think your instructions worked a lot better. I tried being lazy and doing it from the GitHub releases page and it created the tag and release but failed to actually trigger some of the actions. |
https://github.com/bazelbuild/bazel-central-registry/pull/3002/files This was not smooth, I had to extract archives to figure out prefixes to strip, manually copy and edit the MODULE.bazel etc, so if you want to try this next time maybe you should go straight to trying https://github.com/apps/publish-to-bcr. |
Final followup: renovate pulled in the new version and the warning is gone - thank you! |
Getting this a lot:
The reason is that
pybind11_bazel/internal_configure.bzl
Lines 19 to 25 in 0cded48
Would be nice to improve this :)
The text was updated successfully, but these errors were encountered: