Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equivalent circuit models #107

Closed
BradyPlanden opened this issue Nov 20, 2023 · 0 comments · Fixed by #126
Closed

Add equivalent circuit models #107

BradyPlanden opened this issue Nov 20, 2023 · 0 comments · Fixed by #126
Assignees
Labels
enhancement New feature or request priority:high

Comments

@BradyPlanden
Copy link
Member

Feature description

Extend PyBOP's available models by adding PyBaMM's thevenin() model class.

Motivation

No response

Possible implementation

Compose pybamm.thevenin() into pybop.ecm (or similar) following the single particles model template:

class SPM(BaseModel):

To do:

  1. Build requirements
  2. Standarised options
  3. Documentation
  4. Examples
  5. Tests

Additional context

No response

@BradyPlanden BradyPlanden added enhancement New feature or request priority:high labels Nov 20, 2023
@BradyPlanden BradyPlanden moved this to Todo in v23.12 Nov 28, 2023
@BradyPlanden BradyPlanden self-assigned this Nov 28, 2023
@BradyPlanden BradyPlanden mentioned this issue Nov 30, 2023
4 tasks
@BradyPlanden BradyPlanden linked a pull request Nov 30, 2023 that will close this issue
4 tasks
@BradyPlanden BradyPlanden moved this from Todo to In Progress in v23.12 Nov 30, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in v23.12 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:high
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant