Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Fix failing benchmarks #454

Closed
BradyPlanden opened this issue Aug 9, 2024 · 0 comments · Fixed by #457
Closed

[Bug]: Fix failing benchmarks #454

BradyPlanden opened this issue Aug 9, 2024 · 0 comments · Fixed by #457
Assignees
@BradyPlanden
Labels
bug Something isn't working

Comments

@BradyPlanden
Copy link
Member

BradyPlanden commented Aug 9, 2024 •
edited
Loading

Python Version

3.12

Describe the bug

Benchmarks are failing due to the API change to the BaseProblem class in #425. This should be a quick fix, but fast benchmarks should be run on the pull request CI to catch this in advance. We should be able to do this with the `--quick' argument for asv.

Steps to reproduce the behaviour

https://github.com/pybop-team/PyBOP/actions/runs/10302233827/job/28515461543

Relevant log output

No response
@BradyPlanden BradyPlanden added the bug Something isn't working label Aug 9, 2024
@BradyPlanden BradyPlanden self-assigned this Aug 12, 2024
@BradyPlanden BradyPlanden mentioned this issue Aug 13, 2024
Merged
15 tasks
@BradyPlanden BradyPlanden linked a pull request Aug 13, 2024 that will close this issue
Fixes benchmarks #457
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BradyPlanden BradyPlanden

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes benchmarks pybop-team/PyBOP
1 participant
@BradyPlanden