Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in References #5

Open
lucentdan opened this issue Aug 1, 2023 · 2 comments
Open

Spaces in References #5

lucentdan opened this issue Aug 1, 2023 · 2 comments

Comments

@lucentdan
Copy link

Looks like the error referenced here:

https://mattermodeling.stackexchange.com/q/5074

indicates that spaces are not permitted in references within TDB files. The line:

https://github.com/pycalphad/cookbook/blob/9f332a00f8833b120ec1266a991b36b9f1b9e565/PhaseCompositions/mc_fe_v2.059.pycalphad.tdb#L4110C11-L4110C11

Contains four references with spaces. Do you want a pull request to address this data base issue?

@richardotis
Copy link
Contributor

richardotis commented Aug 2, 2023

Unfortunately what's "permitted" and what's allowed by the software have always been two different things for TDB, as there's no official specification for it. The TDBs in this repository are probably out of date (pycalphad used to tolerate spaces in TDB references, and then we changed it, for reasons I do not recall). The databases here should work with the latest (0.10.x) pycalphad versions: https://github.com/materialsgenomefoundation/2023-workshop-material/tree/3b8a4ec1fd5c1409de2834359bc91c6f524a90fa/pycalphad/databases
A PR to merge the appropriate databases here would be welcome.

@richardotis
Copy link
Contributor

I notice that not every TDB in the cookbook is represented in that link. In any case, pull requests restoring compatibility would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants