Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SORT warning in actions.ry #612

Closed
Yachter opened this issue Feb 2, 2019 · 0 comments · Fixed by #613
Closed

SORT warning in actions.ry #612

Yachter opened this issue Feb 2, 2019 · 0 comments · Fixed by #613

Comments

@Yachter
Copy link

Yachter commented Feb 2, 2019

Please fix:
in Lib/site-packages/pandas_datareader/yahoo/actions.py:

ln 36: actions = concat([actions, dividends],sort=True).sort_index(ascending=False)

ln 43: actions = concat([actions, splits],sort=True).sort_index(ascending=False)
@addisonlynch addisonlynch mentioned this issue Feb 3, 2019
Merged
3 tasks
@Yachter Yachter changed the title SORT warning in actions.ru SORT warning in actions.ry Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

COMPAT: Added explicit sort parameter to pd.concat in Yahoo Actions addisonlynch/pandas-datareader
1 participant
@Yachter