From bc35548d96caaec225be9a26afbbaa94069c9494 Mon Sep 17 00:00:00 2001
From: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
Date: Wed, 20 Jan 2021 23:24:04 -0800
Subject: [PATCH] Move skip ci instructions to contributing guide (#4829)
---
.github/PULL_REQUEST_TEMPLATE.md | 8 --------
doc/contributing.rst | 1 +
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 09ef053bb39..c7ea19a53cb 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -5,11 +5,3 @@
- [ ] Passes `pre-commit run --all-files`
- [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst`
- [ ] New functions/methods are listed in `api.rst`
-
-
-
-
- Overriding CI behaviors
-
- By default, the upstream dev CI is disabled on pull request and push events. You can override this behavior per commit by adding a [test-upstream] tag to the first line of the commit message. For documentation-only commits, you can skip the CI per commit by adding a [skip-ci] tag to the first line of the commit message
-
diff --git a/doc/contributing.rst b/doc/contributing.rst
index 9c4ce5a0af2..439791cbbd6 100644
--- a/doc/contributing.rst
+++ b/doc/contributing.rst
@@ -836,6 +836,7 @@ PR checklist
- Write new tests if needed. See `"Test-driven development/code writing" `_.
- Test the code using `Pytest `_. Running all tests (type ``pytest`` in the root directory) takes a while, so feel free to only run the tests you think are needed based on your PR (example: ``pytest xarray/tests/test_dataarray.py``). CI will catch any failing tests.
+ - By default, the upstream dev CI is disabled on pull request and push events. You can override this behavior per commit by adding a [test-upstream] tag to the first line of the commit message. For documentation-only commits, you can skip the CI per commit by adding a "[skip-ci]" tag to the first line of the commit message.
- **Properly format your code** and verify that it passes the formatting guidelines set by `Black `_ and `Flake8 `_. See `"Code formatting" `_. You can use `pre-commit `_ to run these automatically on each commit.