Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for unsigned data #1579

Closed
forman opened this issue Sep 19, 2017 · 3 comments
Closed

Support for unsigned data #1579

forman opened this issue Sep 19, 2017 · 3 comments

Comments

@forman
Copy link

forman commented Sep 19, 2017

The "old" NetCDF 3 format doesn't have explicit support for unsigned integer types and therefore a recommendation/convention exists to set the variable attribute _Unsigned='true', see NetCDF docs, section Unsigned Data.

Are there any plans to interpret the _Unsigned attribute?

I'd really like to help out, but I fear I still don't know enough about dask to provide an efficient PR for that.

My workaround is to manually convert the variables in question which are of type int8, same data as mentioned in #1576:

unsigned_var = signed_int8_var & 0xff

which results in an int16, which is ok but still 1 byte more than the desired uint8.

@jhamman
Copy link
Member

jhamman commented Sep 19, 2017

Didn't #1453 add this?

@forman
Copy link
Author

forman commented Sep 20, 2017

Yes, so this is a duplicate of #1444, sorry!

When can we expect 0.9.7 with the fix?

@forman forman closed this as completed Sep 20, 2017
@shoyer
Copy link
Member

shoyer commented Sep 21, 2017

We are trying to get everything together for a big 0.10 release, so it will be a bit longer. I don't have a timeframe yet, but hopefully in a week or two!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants