-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expanded HTML repr when opening notebook #4041
Comments
me too on Firefox linux |
Same here, Firefox on a Mac. |
Maybe @jsignell can help fix this. |
Yeah I can take a look now. |
Thanks for taking a look @jsignell. Here are some notes I made while trying to reproduce.
There are two output cells with reprs, both of which are not styled correctly. The first cell looks right (and has a style attribute). The second one has auto-updated and looks OK but is missing the style attribute, as well as the click-to-show-data-values functionality. This "auto updating" behaviour is new i.e. wasn't happening last week. I'm on chrome 81 now so maybe all of this is just browser weirdness? |
Huh and if you re-run cell 69 does it render correctly? I'm on chrome 80, but if you were seeing this in firefox as well it seems like it's more likely to be a jupyterlab thing. |
It seems like the auto-update thing works for css, but not for icons. |
Yes the repr works perfectly when re-running these cells. The issue here is when I open an existing notebook with reprs in output cells. I am on firefox beta :/ but yes it could be a jupyterlab thing. |
Does it seem possible that you had originally run it in jlab and then opened it in notebook or vice versa? I've seen html output get kind of messed up under those conditions, but I've never really stopped to debug it thoroughly. |
oh yes that is quite likely. |
Hmm. Ok. I'm still not sure why the html would get messed up under that scenario though. |
Might be explained by #1820 (comment) ? |
Yes that seems like the explanation. Thanks @benbovy! I would expect dask to have the same behavior then since they pass in the style tag in the same way. |
Maybe we could use some sort of hack with HTML hidden attribute and some CSS, in order to show the plain text repr when CSS is not injected... Not ideal but at least it would be better than the HTML repr shown without CSS style. |
I’ve seen similar issues with the seeing unformatted CSS in notebooks on Github. I do think some sort of fallback to pure text mode would be great if we could make it work... |
When I open a notebook, the new HTML repr is "expanded":
I'm running
and see this behaviour with both the notebook and jupyterlab interface; on both chrome and firefox (both on linux).
Is anyone else seeing this?
The text was updated successfully, but these errors were encountered: