Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh on issue bots #5940

Closed
max-sixty opened this issue Nov 4, 2021 · 5 comments
Closed

Refresh on issue bots #5940

max-sixty opened this issue Nov 4, 2021 · 5 comments
Labels
Automation Github bots, testing workflows, release automation

Comments

@max-sixty
Copy link
Collaborator

max-sixty commented Nov 4, 2021

Currently we have two bots which comment on issues, I'd propose we remove them both

  • The "Unit Test Results". I don't find this that useful — do others? I thought it would be listing the tests that failed (I had thought it might even be doing duration changes etc), but it seems to just list the number of tests that failed, which isn't that useful. Or are we not using it correctly?
  • pep8speaks — I think this would be dominated by pre-commit.ci

I'd propose we add:

@TomNicholas
Copy link
Member

I agree with all 3 suggestions

@TomNicholas TomNicholas added the Automation Github bots, testing workflows, release automation label Nov 4, 2021
@Illviljan
Copy link
Contributor

I like pep8speaks because it's faster than the current linting CI. But if we start using the autofixer than that would make pep8speaks redundant.

@keewis
Copy link
Collaborator

keewis commented Nov 5, 2021

the only issues I have with pre-commit.ci is that it autofixes PRs so I have to remember to pull before adding new changes (but I think I can live with that, and the advantage is that lots of new contributors don't have to fight with our CI).

In any case, I'd vote to remove the pre-commit autoupdate CI as that has some quirks that make it difficult to use for everyone other than me.

@max-sixty
Copy link
Collaborator Author

Thanks for the thoughts. I enabled pre-commit.ci so we can see how that goes and remove the others if it's successful.

@andersy005
Copy link
Member

In any case, I'd vote to remove the pre-commit autoupdate CI as that has some quirks that make it difficult to use for everyone other than me.

Once we're satisfied with pre-commit.ci, we should remove https://github.com/pydata/xarray/blob/main/.github/workflows/ci-pre-commit.yml workflow as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Github bots, testing workflows, release automation
Projects
None yet
Development

No branches or pull requests

5 participants