Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy CI is failing on main #6714

Closed
keewis opened this issue Jun 22, 2022 · 1 comment · Fixed by #6706
Closed

mypy CI is failing on main #6714

keewis opened this issue Jun 22, 2022 · 1 comment · Fixed by #6706
Labels
topic-typing

Comments

@keewis
Copy link
Collaborator

keewis commented Jun 22, 2022 •
edited
Loading

The most recent runs of the mypy CI on main are failing with:

xarray/core/dataset.py:6934: error: Incompatible types in assignment (expression has type "str", variable has type "Optional[Optional[Literal['Y', 'M', 'W', 'D', 'h', 'm', 's', 'ms', 'us', 'ns', 'ps', 'fs', 'as']]]")  [assignment]

I'm not sure what changed since the last pass, though.
@headtr1ck
Copy link
Collaborator

Fixed in #6706

@headtr1ck headtr1ck mentioned this issue Jun 22, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Dataset.dtypes property headtr1ck/xarray
2 participants
@keewis @headtr1ck