-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make _obj_repr public #8551
Comments
Does anyone have an objection to this? Otherwise I think we'd accept a PR doing this? |
I do. We should be free to freely change this stuff if/when we want to. @BENR0 please copy this over if you like it :) |
@dcherian indeed we like it :-). We already discussed coping it over and decided not to in order to not repeat code and we think there is actually no need. We totally agree and understand that you want to retain freedom to change things and we are fine with it. Just to add a little more context; what we basically want/do is the "official" html representation of a xarray/xarray/core/formatting_html.py Line 300 in 2971994
I hope that this makes our intention a little bit clearer. |
That isn't public either :) https://docs.xarray.dev/en/stable/getting-started-guide/faq.html#what-parts-of-xarray-are-considered-public-api |
What is your issue?
We are using
xarray/xarray/core/formatting_html.py
Line 278 in 2971994
in the html representation of
AreaDefinitions
in https://github.com/pytroll/pyresample and don't like to import private functions.Would it be OK to make
_obj_repr
public?The text was updated successfully, but these errors were encountered: