Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular import for config #247

Closed
vsoch opened this issue Dec 7, 2022 · 3 comments · Fixed by #248
Closed

Circular import for config #247

vsoch opened this issue Dec 7, 2022 · 3 comments · Fixed by #248

Comments

@vsoch
Copy link
Member

vsoch commented Dec 7, 2022

cc @wetzelj !

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=624731&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d
@vsoch
Copy link
Member Author

vsoch commented Dec 7, 2022

I can do a quick fix.

@vsoch vsoch mentioned this issue Dec 7, 2022
Merged
@vsoch vsoch closed this as completed in #248 Dec 7, 2022
@wetzelj
Copy link
Contributor

wetzelj commented Dec 7, 2022

Thank you. I'm going take a close look at what you do to fix this so that I can learn. It's not an area that I've dealt with, so I was poking around to figure out where the conda-forge deploy config was configured - but it wasn't immediately jumping out.

@vsoch
Copy link
Member Author

vsoch commented Dec 7, 2022

If you just opened a terminal with ipython and did import deid.config it would trigger - not sure why testing didn't catch that! The fix was to have the import that you added within a function so it doesn't happen when everything inits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix import circular error pydicom/deid
2 participants
@vsoch @wetzelj