Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible incorrect coordinate definition #249

Closed
wetzelj opened this issue Dec 14, 2022 · 5 comments
Closed

Possible incorrect coordinate definition #249

wetzelj opened this issue Dec 14, 2022 · 5 comments

Comments

@wetzelj
Copy link
Contributor

wetzelj commented Dec 14, 2022

While reviewing the default deid.dicom file I noticed one greylist filter entry which I believe was incorrectly changed from coordinates to ctpcoordinates.

Stanford Medical Center LightSpeed VCT # (Roger Goldman)

If you agree, I'll submit a PR with this change.
@wetzelj wetzelj changed the title Possible Incorrect coordinate definition Possible incorrect coordinate definition Dec 14, 2022
@vsoch
Copy link
Member

vsoch commented Dec 14, 2022

Yes looks erroneous - sorry that was likely me!

@wetzelj
Copy link
Contributor Author

wetzelj commented Dec 14, 2022

Do you want a version bump and changelog entry on this?

@vsoch
Copy link
Member

vsoch commented Dec 14, 2022

I think this tweak would be OK to merge into main, and either we can wait for the next release (and no bumps but maybe a note) or if you think it's actively hurting someone's pipeline we can do a bump/note. Up to you!

@wetzelj
Copy link
Contributor Author

wetzelj commented Dec 14, 2022

I think it's fine to merge into main and then wait for the next release.

@wetzelj wetzelj mentioned this issue Dec 14, 2022
Merged
3 tasks
@vsoch
Copy link
Member

vsoch commented Dec 14, 2022

Fixed with #250 thanks @wetzelj !

@vsoch vsoch closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vsoch @wetzelj