You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that, when converting workflows containing efficiency nodes, the obtained script fails, unlike the original workflow on ComfyUI. The reason seems to be caused by the fact that these nodes take as input a prompt parameter in their API (ref), which in Comfy seems to be a special type of parameter containing the entire JSON workflow as a python dictionary. The efficiency nodes then use such information to perform optimizations and prune unused tensors.
When not passing prompt to these nodes, the default value None always causes a crash down the line. While it might be argued that the behavior is not a problem of this extension, it's also true that not passing prompt to nodes that accept it might lead to undesirable behavior. In this case, even when handling the lack of prompt gracefully, the efficiency nodes would probably not be able to carry out performance optimizations.
It would be great to update this extension to send prompt as input to the nodes that support it in the generated code.
The text was updated successfully, but these errors were encountered:
I would need the workflow .json you are generating and the .py file created by the extension to better understand the issue. I've made some updates in the last couple of days to make the extension more flexible at accepting additional arguments from nodes, which may already address this issue.
Hello! Thank you for the useful script.
I noticed that, when converting workflows containing efficiency nodes, the obtained script fails, unlike the original workflow on ComfyUI. The reason seems to be caused by the fact that these nodes take as input a
prompt
parameter in their API (ref), which in Comfy seems to be a special type of parameter containing the entire JSON workflow as a python dictionary. The efficiency nodes then use such information to perform optimizations and prune unused tensors.When not passing
prompt
to these nodes, the default valueNone
always causes a crash down the line. While it might be argued that the behavior is not a problem of this extension, it's also true that not passingprompt
to nodes that accept it might lead to undesirable behavior. In this case, even when handling the lack ofprompt
gracefully, the efficiency nodes would probably not be able to carry out performance optimizations.It would be great to update this extension to send
prompt
as input to the nodes that support it in the generated code.The text was updated successfully, but these errors were encountered: