Code

Bug pylint 4206#921

Code

Merged

cdce8p merged 61 commits intopylint-dev:masterpylint-dev/astroid:masterfrom hippo91:bug_pylint_4206hippo91/astroid:bug_pylint_4206Copy head branch name to clipboardApr 6, 2021

+413-101

Commits

Commits on Mar 13, 2021

• Takes into account the fact that inferring subscript when the node is a class may use the __class_getitem__ method of the current class instead of looking for __getitem__ in the metaclass.

  hippo91

  committed
  1beb629

• OrderedDict in the collections module inherit from dict which is C coded and thus have no metaclass but starting from python3.9 it supports subscripting thanks to the __class_getitem__ method.

  hippo91

  committed
  4c85bd0

• check_metaclass becomes a static class method because we need it in the class scope.

  Show description for 99a078b
  hippo91

  committed
  99a078b

• The brain_typing module does not add anymore _typing suffixed classes in the mro

  hippo91

  committed
  32d89e2

• The OrderedDict class inherits from C coded dict class and thus doesn't have a metaclass.

  hippo91

  committed
  65a8f88

• When trying to inherit from typing.Pattern the REPL says : TypeError: type 're.Pattern' is not an acceptable base type

  hippo91

  committed
  0dee7f8

• The REPL says that Derived as ABCMeta for metaclass and the mro is Derived => Iterator => Iterable => object

  hippo91

  committed
  450fae1

Commits on Mar 14, 2021

• Adds comments

  hippo91

  committed
  eac3ad1

• Starting with Python39 some collections of the collections.abc module support subscripting thanks to __class_getitem__ method. However the wat it is implemented is not straigthforward and instead o…

  Show description for 2c711e7
  hippo91

  committed
  2c711e7

• Thanks to __class_getitem__ method there is no need to hack the metaclass

  hippo91

  committed
  542eb9c

• SImplifies the inference system for typing objects before python3.9. Before python3.9 the objects of the typing module that are alias of the same objects in the collections.abc module have subscrip…

  Show description for f5aef79
  hippo91

  committed
  f5aef79

• check_metaclass_is_abc become global to be shared among different classes

  hippo91

  committed
  84c576c

• Create a test class dedicated to the Collections brain

  hippo91

  committed
  20ca3a1

• Rewrites and adds test

  hippo91

  committed
  66c4c7c

• Corrects syntax error

  hippo91

  committed
  8c7d344

• Deque, defaultdict and OrderedDict are part of the _collections module which is a pure C lib. While letting those class mocks inside collections module is fair for astroid it leds to pylint accepta…

  Show description for c392180
  hippo91

  committed
  c392180

• Formatting according to black

  hippo91

  committed
  b0d13d1

• Adds two entries

  hippo91

  committed
  ab26675

• Extends the filter to determine what is subscriptable to include OrderedDict

  hippo91

  committed
  230fee4

• Formatting according to black

  hippo91

  committed
  79b502c

Commits on Mar 21, 2021

• Takes into account the fact that inferring subscript when the node is a class may use the __class_getitem__ method of the current class instead of looking for __getitem__ in the metaclass.

  hippo91

  committed
  91ce864

• OrderedDict in the collections module inherit from dict which is C coded and thus have no metaclass but starting from python3.9 it supports subscripting thanks to the __class_getitem__ method.

  hippo91

  committed
  136169b

• check_metaclass becomes a static class method because we need it in the class scope.

  Show description for 4e4e27f
  hippo91

  committed
  4e4e27f

• The brain_typing module does not add anymore _typing suffixed classes in the mro

  hippo91

  committed
  324f02c

• The OrderedDict class inherits from C coded dict class and thus doesn't have a metaclass.

  hippo91

  committed
  3babaf4

• When trying to inherit from typing.Pattern the REPL says : TypeError: type 're.Pattern' is not an acceptable base type

  hippo91

  committed
  a1f1dd6

• The REPL says that Derived as ABCMeta for metaclass and the mro is Derived => Iterator => Iterable => object

  hippo91

  committed
  92a9422

• Adds comments

  hippo91

  committed
  7afcd62

• Starting with Python39 some collections of the collections.abc module support subscripting thanks to __class_getitem__ method. However the wat it is implemented is not straigthforward and instead o…

  Show description for 7b16e00
  hippo91

  committed
  7b16e00

• Thanks to __class_getitem__ method there is no need to hack the metaclass

  hippo91

  committed
  5b56836

• SImplifies the inference system for typing objects before python3.9. Before python3.9 the objects of the typing module that are alias of the same objects in the collections.abc module have subscrip…

  Show description for 6f4328a
  hippo91

  committed
  6f4328a

• check_metaclass_is_abc become global to be shared among different classes

  hippo91

  committed
  a38e82d

• Create a test class dedicated to the Collections brain

  hippo91

  committed
  121a3db

• Rewrites and adds test

  hippo91

  committed
  0654a69

• Corrects syntax error

  hippo91

  committed
  2e382de

• Deque, defaultdict and OrderedDict are part of the _collections module which is a pure C lib. While letting those class mocks inside collections module is fair for astroid it leds to pylint accepta…

  Show description for 86bd75a
  hippo91

  committed
  86bd75a

• Formatting according to black

  hippo91

  committed
  eb87d79

• Adds two entries

  hippo91

  committed
  5d58132

• Extends the filter to determine what is subscriptable to include OrderedDict

  hippo91

  committed
  fa7b6e7

• Formatting according to black

  hippo91

  committed
  d8759f3

• Takes into account @AWhetter remarks

  hippo91

  committed
  d8ee527

• Deactivates access to __class_getitem__ method

  hippo91

  committed
  8ff2893

Commits on Mar 27, 2021

• Merge branch 'bug_pylint_4206' of https://github.com/hippo91/astroid into bug_pylint_4206

  hippo91

  committed
  01c7d3c

• OrderedDict appears in typing module with python3.7.2

  hippo91

  committed
  0f875c8

• _alias function in the typing module appears with python3.7

  hippo91

  committed
  edf1503

• Formatting according to black

  hippo91

  committed
  3357204

• _alias function is used also for builtins type and not only for collections.abc ones

  hippo91

  committed
  38cf33c

Commits on Mar 29, 2021

• Adds tests for both builtins type that are subscriptable and typing builtin alias type that are also subscriptable

  hippo91

  committed
  15bdc78

• No need to handle builtin types in this brain. It is better suited inside brain_bulitin_inference

  hippo91

  committed
  c5d1c40

• Adds brain to handle builtin types that are subscriptable starting with python39

  hippo91

  committed
  ede0e00

• Formatting according to black

  hippo91

  committed
  a09f838

Commits on Mar 31, 2021

• Uses partial function instead of closure in order pylint acceptance to be ok

  hippo91

  committed
  d71a7aa

• Handling the __class_getitem__ method associated to EmptyNode for builtin types is made directly inside the getitem method

  hippo91

  committed
  1be6d3f

• infer_typing_alias has to be an inference_tip to avoid interferences between typing module and others (collections or builtin)

  hippo91

  committed
  aaa9543

• Formatting

  hippo91

  committed
  56ab112

• Merge branch 'master' into bug_pylint_4206

  hippo91

  committed
  9c42d28

• Removes useless code

  hippo91

  committed
  80b8ca9

• Adds comment

  hippo91

  committed
  30b1e79

Commits on Apr 2, 2021

• Takes into account @cdce8p remarks

  hippo91

  committed
  0bc7d6b

Commits on Apr 4, 2021

• Formatting

  hippo91

  committed
  5cd0fcb

Commits on Apr 6, 2021

• Style changes

  cdce8p

  committed
  2d56141