Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checker async.py couldn't be imported anywhere because it uses reserved word. #10071

Closed
bgb10 opened this issue Nov 5, 2024 · 2 comments
Closed

Comments

@bgb10
Copy link
Contributor

bgb10 commented Nov 5, 2024

Current problem

Wanted to make test code for async checkers, but since name of async checker is async.py, AsyncChecker class in this file cannot be imported anywhere. ('async' is keyword!) Indeed, we imported this nowhere before (just registered checker to linter as below), but to write test code for AsyncChecker, file rename is must.

Desired solution

So renamed async.py to async_checker.py.

Additional context

PR: #10060

@bgb10 bgb10 added the Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling label Nov 5, 2024
@bgb10
Copy link
Contributor Author

bgb10 commented Nov 5, 2024

I created PR at first, and made this to write changelog 😄

@Pierre-Sassoulas Pierre-Sassoulas added Breaking changes for 4.0 🦤 and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Nov 5, 2024
@Pierre-Sassoulas Pierre-Sassoulas added this to the 4.0.0 milestone Nov 5, 2024
@Pierre-Sassoulas
Copy link
Member

Thank you. You can refs the pull request directly next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants