Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less than equal PyMC Version #164

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

juanitorduz
Copy link
Contributor

Motivated by #163 (comment)

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it doesn't matter right now, but it's better to put <5.16 to allow for the possibility of 5.15.1, which in principle should not include any breaking changes.

@juanitorduz juanitorduz requested a review from maresb May 14, 2024 08:17
@juanitorduz
Copy link
Contributor Author

Yes! Makes sense!

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @juanitorduz!

@maresb
Copy link
Contributor

maresb commented May 14, 2024

Perhaps we should do a 0.5.14 release with just this so that people aren't required to upgrade pymc to 5.15.0 to install the latest pymc-bart.

@aloctavodia aloctavodia merged commit b7b0902 into main May 14, 2024
4 checks passed
@aloctavodia aloctavodia deleted the less_than_equal_pymc_version branch May 14, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants