Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove size from signature and raise warning if used #5789

Closed
twiecki opened this issue May 20, 2022 · 2 comments
Closed

Remove size from signature and raise warning if used #5789

twiecki opened this issue May 20, 2022 · 2 comments
Milestone
v4.0.0

Comments

@twiecki
Copy link
Member

twiecki commented May 20, 2022

Ref #5754
@twiecki twiecki added this to the v4.0.0 milestone May 20, 2022
@twiecki twiecki mentioned this issue May 20, 2022
Merged
@mjhajharia
Copy link
Member

is this done, now that #5788 is merged

@michaelosthege
Copy link
Member

In my opinion yes.

We can add warnings to nudge users towards certain API flavors in a patch release, so this should no longer block 4.0.0.

I'll close this issue. Proposals to add UserWarnings should be made in new, much more specific issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
3 participants
@twiecki @michaelosthege @mjhajharia