From 362c3031caf948ed64a46e3d3691ca8791ac2e1d Mon Sep 17 00:00:00 2001 From: p0ps Date: Fri, 25 Sep 2020 20:20:15 +0200 Subject: [PATCH] Fix article sort reversed (#8532) * Reverse the article sorting implementation. (The, a, an) sorting was working inverted. * bundle * yarn test -u * yarn dev Co-authored-by: Dario --- .../src/components/helpers/show-selector.vue | 2 +- .../slim/src/components/show-list/poster.vue | 2 +- .../__snapshots__/show-selector.spec.js.snap | 40 +++++++++---------- themes/dark/assets/js/medusa-runtime.js | 4 +- themes/light/assets/js/medusa-runtime.js | 4 +- 5 files changed, 26 insertions(+), 26 deletions(-) diff --git a/themes-default/slim/src/components/helpers/show-selector.vue b/themes-default/slim/src/components/helpers/show-selector.vue index dbe4c51975..76cf811d25 100644 --- a/themes-default/slim/src/components/helpers/show-selector.vue +++ b/themes-default/slim/src/components/helpers/show-selector.vue @@ -58,7 +58,7 @@ export default { const sortedShows = [...showsInLists]; - const sortKey = title => (sortArticle ? title.replace(/^((?:the|a|an)\s)/i, '') : title).toLowerCase(); + const sortKey = title => (sortArticle ? title : title.replace(/^((?:the|a|an)\s)/i, '')).toLowerCase(); const sortFn = (showA, showB) => { const titleA = sortKey(showA.title); const titleB = sortKey(showB.title); diff --git a/themes-default/slim/src/components/show-list/poster.vue b/themes-default/slim/src/components/show-list/poster.vue index 0636aecb02..8c9aaafbd4 100644 --- a/themes-default/slim/src/components/show-list/poster.vue +++ b/themes-default/slim/src/components/show-list/poster.vue @@ -100,7 +100,7 @@ export default { const { stateLayout } = this; const { sortArticle } = stateLayout; - if (!sortArticle) { + if (sortArticle) { return row.title; } diff --git a/themes-default/slim/test/specs/__snapshots__/show-selector.spec.js.snap b/themes-default/slim/test/specs/__snapshots__/show-selector.spec.js.snap index 08d1127ba9..d67aa64eee 100644 --- a/themes-default/slim/test/specs/__snapshots__/show-selector.spec.js.snap +++ b/themes-default/slim/test/specs/__snapshots__/show-selector.spec.js.snap @@ -60,14 +60,14 @@ exports[`ShowSelector.test.js renders with articles(The|A|An) ignored in /home/d label="Anime" >